Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Add system info module to check platform properties #26325

Merged
merged 4 commits into from
May 4, 2023

Conversation

wootak-jung
Copy link
Contributor

Problem

bt_adapter_le_set_advertising_flags() is available since Tizen 7.5.

Changes

  • add system info module to check platform properties
  • add check logic of tizen version before calling bt_adapter_le_set_advertising_flags()

Testing

CI will test potential build failures. Functionality tested locally on Tizen device.

src/platform/Tizen/SystemInfo.cpp Outdated Show resolved Hide resolved
src/platform/Tizen/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26325: Size comparison from fa505f6 to d90eb62

Decreases (1 build for cc32xx)
platform target config section fa505f6 d90eb62 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19559510 19559509 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section fa505f6 d90eb62 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604042 604042 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956764 956764 0 0.0
.debug_aranges 103240 103240 0 0.0
.debug_frame 349432 349432 0 0.0
.debug_info 19559510 19559509 -1 -0.0
.debug_line 2687404 2687404 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1515630 1515630 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 95966 95966 0 0.0
.debug_str 3082308 3082308 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104282 104282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 479192 479192 0 0.0
.symtab 286736 286736 0 0.0
.text 497636 497636 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496168 2496168 0 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1458852 1458852 0 0.0

@github-actions
Copy link

github-actions bot commented May 3, 2023

PR #26325: Size comparison from 328c553 to 30a4d2a

Increases (1 build for cc32xx)
platform target config section 328c553 30a4d2a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19511288 19511289 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 328c553 30a4d2a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956917 956917 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511288 19511289 1 0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496432 2496432 0 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1459116 1459116 0 0.0

Copy link
Contributor

@dh79pyun dh79pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@hyunuktak hyunuktak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arkq arkq merged commit dbf2430 into project-chip:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants