-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve configure script so ninja can be run without a wrapper #26379
Merged
ksperling-apple
merged 2 commits into
project-chip:master
from
ksperling-apple:configure-no-activate
May 10, 2023
Merged
Improve configure script so ninja can be run without a wrapper #26379
ksperling-apple
merged 2 commits into
project-chip:master
from
ksperling-apple:configure-no-activate
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by using gn --script-executable to make Python scripts / actions use the venv without having to activate it first. Tweak zap_execution.py to look for zap-cli in the venv bin directory in preference to PATH so this works for code generation. Plus some minor improvements: - Remove special casing of the build environment directory for in-tree builds and be more helpful when running configure without arguments. - Handle VAR=VALUE arguments as environment variable assignments - Guess CXX based on whether cc appears to be gcc or clang when CC and CXX are not provided.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
lazarkov
May 5, 2023 02:45
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 5, 2023 02:45
PR #26379: Size comparison from 9556cc3 to 38575f2 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
reviewed
May 5, 2023
andy31415
reviewed
May 5, 2023
ksperling-apple
force-pushed
the
configure-no-activate
branch
2 times, most recently
from
May 6, 2023 03:38
14c4633
to
e3c22fd
Compare
ksperling-apple
force-pushed
the
configure-no-activate
branch
from
May 6, 2023 03:43
e3c22fd
to
b8edd5c
Compare
PR #26379: Size comparison from c984f0b to b8edd5c Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 6, 2023
andy31415
reviewed
May 8, 2023
andy31415
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using
gn --script-executable
to make Python scripts / actions use the venv without having to activate it first.Tweak zap_execution.py to look for zap-cli in the venv bin directory in preference to PATH so this works for code generation.Plus some minor improvements: