Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] [EFR32] Refactor 917 NCP and 917 SoC Bluetooth to use the same implementation #26390

Conversation

shgutte
Copy link
Contributor

@shgutte shgutte commented May 5, 2023

Problem
There are only some code changes in RS9116 and RS9117 BLE implementation, which is the code's repetition.

Fixes added
Refactored In such a way that one file will work for both RS9116 and RS9117 implementation.

Testing
I tested with all combinations of RS9116 and RS9117.

@github-actions
Copy link

github-actions bot commented May 5, 2023

PR #26390: Size comparison from 42138c4 to aebe438

Increases (1 build for cc32xx)
platform target config section 42138c4 aebe438 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19603114 19603115 1 0.0
Full report (1 build for cc32xx)
platform target config section 42138c4 aebe438 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957098 957098 0 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19603114 19603115 1 0.0
.debug_line 2666235 2666235 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488792 1488792 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3108084 3108084 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

src/platform/silabs/rs911x/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
third_party/silabs/efr32_sdk.gni Show resolved Hide resolved
third_party/silabs/SiWx917_sdk.gni Show resolved Hide resolved
src/platform/silabs/rs911x/wfx_sl_ble_init.c Outdated Show resolved Hide resolved
src/platform/silabs/rs911x/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) May 9, 2023 12:47
@jmartinez-silabs jmartinez-silabs merged commit 38466c2 into project-chip:master May 9, 2023
@shgutte shgutte deleted the refactor/ble_changes_for_rs9116_and_rs9117 branch May 9, 2023 13:20
shgutte added a commit to shgutte/connectedhomeip that referenced this pull request Jun 7, 2023
…me implementation (project-chip#26390)

* Refactor 917 NCP and 917 SoC bluetooth to use the same implementation file

* Restyled by gn

* Added changes for coding standard

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants