-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] [EFR32] Refactor 917 NCP and 917 SoC Bluetooth to use the same implementation #26390
Merged
jmartinez-silabs
merged 3 commits into
project-chip:master
from
shgutte:refactor/ble_changes_for_rs9116_and_rs9117
May 9, 2023
Merged
[Silabs] [EFR32] Refactor 917 NCP and 917 SoC Bluetooth to use the same implementation #26390
jmartinez-silabs
merged 3 commits into
project-chip:master
from
shgutte:refactor/ble_changes_for_rs9116_and_rs9117
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
May 5, 2023 13:33
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 5, 2023 13:33
PR #26390: Size comparison from 42138c4 to aebe438 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
mkardous-silabs
requested changes
May 5, 2023
mkardous-silabs
approved these changes
May 8, 2023
andy31415
approved these changes
May 8, 2023
jmartinez-silabs
approved these changes
May 9, 2023
shgutte
added a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jun 7, 2023
…me implementation (project-chip#26390) * Refactor 917 NCP and 917 SoC bluetooth to use the same implementation file * Restyled by gn * Added changes for coding standard --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are only some code changes in RS9116 and RS9117 BLE implementation, which is the code's repetition.
Fixes added
Refactored In such a way that one file will work for both RS9116 and RS9117 implementation.
Testing
I tested with all combinations of RS9116 and RS9117.