-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temperature-control cluster xml and generate zap #26548
Add temperature-control cluster xml and generate zap #26548
Conversation
jadhavrohit924
commented
May 12, 2023
- Changes:
- Testing
@jadhavrohit924 Merge conflicts; needs a regen. |
45c173a
to
651ac02
Compare
PR #26548: Size comparison from 64bf867 to 651ac02 Increases above 0.2%:
Increases (18 builds for bl602, bl702, cc32xx, linux, psoc6, telink)
Decreases (7 builds for bl602, esp32, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@jadhavrohit924 Would you mind taking a peek at the merge conflicts? |
@woody-apple There are no merge conflicts; this is just blocked on non-Apple review. |
src/app/zap-templates/zcl/data-model/chip/temperature-control-cluster.xml
Show resolved
Hide resolved
651ac02
to
cffeed4
Compare
PR #26548: Size comparison from ca83f16 to cffeed4 Increases above 0.2%:
Increases (25 builds for bl602, bl702, cc32xx, efr32, esp32, linux, psoc6, telink)
Decreases (9 builds for bl702, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/temperature-control-cluster.xml
Outdated
Show resolved
Hide resolved
PR #26548: Size comparison from ca83f16 to 2080b3d Increases above 0.2%:
Increases (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for bl702)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This may need a rebase to tip to fix the ZAP CI issue, since it got updated while tip was broken... @jadhavrohit924 |
2080b3d
to
eb5634a
Compare
PR #26548: Size comparison from 21147a5 to eb5634a Increases (9 builds for bl702, cc32xx, linux, psoc6)
Decreases (5 builds for bl702, cyw30739, efr32, qpg)
Full report (28 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
@jadhavrohit924
|
@dhrishi @jadhavrohit924 Those two files need to be added to the outputs list in |
PR #26548: Size comparison from 21147a5 to 418de17 Increases above 0.2%:
Increases (27 builds for bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (6 builds for cyw30739, efr32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple Thanks for help :) |