-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow chip-tool/darwin-framework-tool vendor id to be customised #26575
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:chiptool_dft_custom_vendorid
May 23, 2023
Merged
Allow chip-tool/darwin-framework-tool vendor id to be customised #26575
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:chiptool_dft_custom_vendorid
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
May 15, 2023
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.h
Outdated
Show resolved
Hide resolved
PR #26575: Size comparison from b4fb147 to 5aeb490 Increases (5 builds for bl602, bl702, cc32xx)
Decreases (1 build for qpg)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
5aeb490
to
c406553
Compare
PR #26575: Size comparison from b4fb147 to c406553 Increases (11 builds for bl602, cc32xx, linux, psoc6, telink)
Decreases (9 builds for bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
krypton36
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
andy31415
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no mechanism to customise the vendor id used by
chip-tool
or by thedarwin-framework-tool
.This PR adds such a mechanism but keeps using
chip::VendorId::TestVendor1
as the default.