Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] MTRDevice estimate start time based on General Diagnostics UpTime attribute when present #26583

Merged
merged 5 commits into from
May 18, 2023
Merged

[Darwin] MTRDevice estimate start time based on General Diagnostics UpTime attribute when present #26583

merged 5 commits into from
May 18, 2023

Conversation

jtung-apple
Copy link
Contributor

MTRDevice currently estimates device start time (for devices that don't have a wall clock) by subtracting the event time value from "now". This estimate can get better over time as events get reported, but initially could be off by a lot, if there are no freshly generated events in the priming report at subscription establishment time.

This change improves the estimate by making an estimated start time if the General Diagnostics UpTime attribute is seen in the priming report, and at OnSubscriptionEstablished callback, update the estimate if it's better.

Note for reviewer: the MTRTimeIntervalForEventTimestampValue function needed to be moved so the compiler is not confused about multiple definitions, now that it's exported for MTRDevice.mm to also use.

@jtung-apple jtung-apple self-assigned this May 15, 2023
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

PR #26583: Size comparison from b4fb147 to 55626ab

Increases (6 builds for bl602, bl702, cc32xx, psoc6)
platform target config section b4fb147 55626ab change % change
bl602 lighting-app bl602 (read/write) 1355002 1355010 8 0.0
.text 1035984 1035986 2 0.0
bl602+rpc .text 1067340 1067342 2 0.0
bl702 lighting-app bl702 .debug_info 40947051 40947052 1 0.0
.text 965478 965480 2 0.0
bl702+rpc .debug_info 45852868 45852869 1 0.0
.text 1038106 1038108 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19678441 19678442 1 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27010787 27010788 1 0.0
Decreases (1 build for qpg)
platform target config section b4fb147 55626ab change % change
qpg lock-app qpg6105+debug (read/write) 1139500 1139492 -8 -0.0
.text 586600 586592 -8 -0.0
Full report (36 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section b4fb147 55626ab change % change
bl602 lighting-app bl602 (read/write) 1355002 1355010 8 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035984 1035986 2 0.0
bl602+rpc (read/write) 1401278 1401278 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067340 1067342 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1185791 1185791 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1551184 1551184 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488808 488808 0 0.0
.debug_info 40947051 40947052 1 0.0
.debug_line 5303308 5303308 0 0.0
.debug_loc 3424642 3424642 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708369 3708369 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106320 106320 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580869 580869 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
965478 965480 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273571 1273571 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1707934 1707934 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516780 516780 0 0.0
.debug_info 45852868 45852869 1 0.0
.debug_line 5718212 5718212 0 0.0
.debug_loc 3626890 3626890 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133474 4133474 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641539 641539 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1038106 1038108 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605018 605018 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 958615 958615 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342084 342084 0 0.0
.debug_info 19678441 19678442 1 0.0
.debug_line 2673606 2673606 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491157 1491157 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131974 3131974 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483172 483172 0 0.0
.symtab 287232 287232 0 0.0
.text 498572 498572 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524283 524283 0 0.0
.app_xip_area 417077 417077 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528963 528963 0 0.0
.app_xip_area 416453 416453 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566115 566115 0 0.0
.app_xip_area 459669 459669 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530875 530875 0 0.0
.app_xip_area 421861 421861 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read only) 583460 583460 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 582924 582924 0 0.0
light k32w0+release (read only) 582316 582316 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581780 581780 0 0.0
lock k32w0+release (read only) 555836 555836 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555300 555300 0 0.0
linux all-clusters-app debug (read only) 3137157 3137157 0 0.0
(read/write) 152320 152320 0 0.0
.bss 60032 60032 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 83640 83640 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 228712 228712 0 0.0
.text 2722805 2722805 0 0.0
all-clusters-minimal-app debug (read only) 2950765 2950765 0 0.0
(read/write) 145536 145536 0 0.0
.bss 59200 59200 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222472 222472 0 0.0
.text 2546069 2546069 0 0.0
bridge-app debug (read only) 2514373 2514373 0 0.0
(read/write) 129328 129328 0 0.0
.bss 49944 49944 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69552 69552 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 171656 171656 0 0.0
.text 2170469 2170469 0 0.0
chip-tool debug (read only) 12979665 12979665 0 0.0
(read/write) 695592 695592 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 659336 659336 0 0.0
.dynamic 608 608 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 623629 623629 0 0.0
.text 10738708 10738708 0 0.0
chip-tool-ipv6only arm64 (read only) 12263932 12263932 0 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570752 570752 0 0.0
.text 9920372 9920372 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2577989 2577989 0 0.0
(read/write) 126520 126520 0 0.0
.bss 47256 47256 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 70136 70136 0 0.0
.dynamic 624 624 0 0.0
.got 4800 4800 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 174376 174376 0 0.0
.text 2226325 2226325 0 0.0
lighting-app debug+rpc+ui (read only) 3240977 3240977 0 0.0
(read/write) 132112 132112 0 0.0
.bss 47936 47936 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 74680 74680 0 0.0
.dynamic 656 656 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 283060 283060 0 0.0
.text 2766194 2766194 0 0.0
lock-app debug (read only) 2653213 2653213 0 0.0
(read/write) 123464 123464 0 0.0
.bss 45856 45856 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204712 204712 0 0.0
.text 2275877 2275877 0 0.0
ota-provider-app debug (read only) 2206229 2206229 0 0.0
(read/write) 103608 103608 0 0.0
.bss 44496 44496 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 51888 51888 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 152808 152808 0 0.0
.text 1911973 1911973 0 0.0
ota-requestor-app debug (read only) 2373213 2373213 0 0.0
(read/write) 111304 111304 0 0.0
.bss 46864 46864 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56744 56744 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 156872 156872 0 0.0
.text 2066021 2066021 0 0.0
shell debug (read only) 2673993 2673993 0 0.0
(read/write) 140808 140808 0 0.0
.bss 58984 58984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 74760 74760 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 197202 197202 0 0.0
.text 2315010 2315010 0 0.0
thermostat-no-ble arm64 (read only) 2519156 2519156 0 0.0
(read/write) 142392 142392 0 0.0
.bss 53464 53464 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 560 560 0 0.0
.got 5424 5424 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 129256 129256 0 0.0
.text 2126628 2126628 0 0.0
tv-app debug (read only) 3308665 3308665 0 0.0
(read/write) 261224 261224 0 0.0
.bss 170976 170976 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79424 79424 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 220856 220856 0 0.0
.text 2891698 2891698 0 0.0
tv-casting-app debug (read only) 6801553 6801553 0 0.0
(read/write) 185552 185552 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 125184 125184 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 308684 308684 0 0.0
.text 6147938 6147938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495064 2495064 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457748 1457748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176356 1176356 0 0.0
bss 155563 155563 0 0.0
rodata 132756 132756 0 0.0
text 807284 807284 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436084 1436084 0 0.0
bss 135303 135303 0 0.0
rodata 228772 228772 0 0.0
text 777944 777944 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123464 1123464 0 0.0
bss 154757 154757 0 0.0
rodata 109752 109752 0 0.0
text 778220 778220 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840680 840680 0 0.0
(read/write) 1706636 1706636 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190108 190108 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1285336 1285336 0 0.0
.debug_aranges 128296 128296 0 0.0
.debug_frame 425812 425812 0 0.0
.debug_info 27010787 27010788 1 0.0
.debug_line 3761460 3761460 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2021763 2021763 0 0.0
.debug_rnglists 128096 128096 0 0.0
.debug_str 3640280 3640280 0 0.0
.heap 840680 840680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 716254 716254 0 0.0
.symtab 466336 466336 0 0.0
.text 1505588 1505588 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841440 841440 0 0.0
(read/write) 1648964 1648964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1280142 1280142 0 0.0
.debug_aranges 127768 127768 0 0.0
.debug_frame 428880 428880 0 0.0
.debug_info 26786852 26786852 0 0.0
.debug_line 3784161 3784161 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2014857 2014857 0 0.0
.debug_rnglists 127260 127260 0 0.0
.debug_str 3631982 3631982 0 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674942 674942 0 0.0
.symtab 451648 451648 0 0.0
.text 1448676 1448676 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1570596 1570596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1112592 1112592 0 0.0
.debug_aranges 117920 117920 0 0.0
.debug_frame 392116 392116 0 0.0
.debug_info 22308529 22308529 0 0.0
.debug_line 3347159 3347159 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1846371 1846371 0 0.0
.debug_rnglists 116889 116889 0 0.0
.debug_str 3437961 3437961 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 590995 590995 0 0.0
.symtab 414096 414096 0 0.0
.text 1378604 1378604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627100 1627100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1111608 1111608 0 0.0
.debug_aranges 118424 118424 0 0.0
.debug_frame 394208 394208 0 0.0
.debug_info 22488412 22488412 0 0.0
.debug_line 3343541 3343541 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1859798 1859798 0 0.0
.debug_rnglists 117345 117345 0 0.0
.debug_str 3452943 3452943 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 594996 594996 0 0.0
.symtab 416400 416400 0 0.0
.text 1407324 1407324 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1169632 1169632 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616732 616732 0 0.0
lock-app qpg6105+debug (read/write) 1139500 1139492 -8 -0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586600 586592 -8 -0.0

@jtung-apple jtung-apple force-pushed the jtung/darwin-mtrdevice-better-estimated-start-time branch from 55626ab to 956cf58 Compare May 15, 2023 18:22
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

PR #26583: Size comparison from b4fb147 to 956cf58

Increases (14 builds for bl602, bl702, cc32xx, psoc6, telink)
platform target config section b4fb147 956cf58 change % change
bl602 lighting-app bl602 (read/write) 1355002 1355010 8 0.0
.text 1035984 1035988 4 0.0
bl602+rpc .text 1067340 1067344 4 0.0
bl702 lighting-app bl702 .debug_info 40947051 40947052 1 0.0
.text 965478 965480 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19678441 19678442 1 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27010787 27010788 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22488412 22488413 1 0.0
telink all-clusters-app tlsr9518adk80d text 680014 680016 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 937808 937816 8 0.0
text 642580 642582 2 0.0
bridge-app tlsr9518adk80d text 635222 635226 4 0.0
contact-sensor-app tlsr9518adk80d text 575448 575452 4 0.0
lighting-app tlsr9518adk80d text 652262 652264 2 0.0
ota-requestor-app tlsr9518adk80d text 597546 597548 2 0.0
pump-app tlsr9518adk80d text 581470 581472 2 0.0
pump-controller-app tlsr9518adk80d text 571746 571748 2 0.0
Decreases (8 builds for esp32, psoc6, telink)
platform target config section b4fb147 956cf58 change % change
esp32 all-clusters-app c3devkit (read only) 1053040 1053038 -2 -0.0
.flash.text 1053040 1053038 -2 -0.0
m5stack (read/write) 492586 492582 -4 -0.0
.flash.rodata 240980 240976 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26786852 26786851 -1 -0.0
telink light-switch-app tlsr9518adk80d text 590080 590076 -4 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 945812 945804 -8 -0.0
text 659820 659816 -4 -0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1002676 1002668 -8 -0.0
text 695974 695972 -2 -0.0
lock-app tlsr9518adk80d text 603940 603938 -2 -0.0
window-covering tlsr9518adk80d text 587482 587480 -2 -0.0
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b4fb147 956cf58 change % change
bl602 lighting-app bl602 (read/write) 1355002 1355010 8 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035984 1035988 4 0.0
bl602+rpc (read/write) 1401278 1401278 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067340 1067344 4 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1185791 1185791 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1551184 1551184 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488808 488808 0 0.0
.debug_info 40947051 40947052 1 0.0
.debug_line 5303308 5303308 0 0.0
.debug_loc 3424642 3424642 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708369 3708369 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106320 106320 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580869 580869 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
965478 965480 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273571 1273571 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1707934 1707934 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516780 516780 0 0.0
.debug_info 45852868 45852868 0 0.0
.debug_line 5718212 5718212 0 0.0
.debug_loc 3626890 3626890 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133474 4133474 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641539 641539 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1038106 1038106 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605018 605018 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 958615 958615 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342084 342084 0 0.0
.debug_info 19678441 19678442 1 0.0
.debug_line 2673606 2673606 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491157 1491157 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131974 3131974 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483172 483172 0 0.0
.symtab 287232 287232 0 0.0
.text 498572 498572 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524283 524283 0 0.0
.app_xip_area 417077 417077 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528963 528963 0 0.0
.app_xip_area 416453 416453 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566115 566115 0 0.0
.app_xip_area 459669 459669 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530875 530875 0 0.0
.app_xip_area 421861 421861 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 964076 964076 0 0.0
.bss 179672 179672 0 0.0
.data 2136 2136 0 0.0
.text 782248 782248 0 0.0
BRD4187C (read/write) 1000784 1000784 0 0.0
.bss 159420 159420 0 0.0
.data 2780 2780 0 0.0
.text 838564 838564 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068604 1068604 0 0.0
.bss 174144 174144 0 0.0
.data 2152 2152 0 0.0
.text 892288 892288 0 0.0
window-app BRD4187C (read/write) 1075816 1075816 0 0.0
.bss 143876 143876 0 0.0
.data 2676 2676 0 0.0
.text 929244 929244 0 0.0
esp32 all-clusters-app c3devkit (read only) 1053040 1053038 -2 -0.0
(read/write) 1583408 1583408 0 0.0
.dram0.bss 77136 77136 0 0.0
.dram0.data 13968 13968 0 0.0
.flash.rodata 213176 213176 0 0.0
.flash.text 1053040 1053038 -2 -0.0
.iram0.text 76708 76708 0 0.0
m5stack (read only) 1100919 1100919 0 0.0
(read/write) 492586 492582 -4 -0.0
.dram0.bss 82152 82152 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 240980 240976 -4 -0.0
.flash.text 1095535 1095535 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 583460 583460 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 582924 582924 0 0.0
light k32w0+release (read only) 582316 582316 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581780 581780 0 0.0
lock k32w0+release (read only) 555836 555836 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555300 555300 0 0.0
linux all-clusters-app debug (read only) 3137157 3137157 0 0.0
(read/write) 152320 152320 0 0.0
.bss 60032 60032 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 83640 83640 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 228712 228712 0 0.0
.text 2722805 2722805 0 0.0
all-clusters-minimal-app debug (read only) 2950765 2950765 0 0.0
(read/write) 145536 145536 0 0.0
.bss 59200 59200 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222472 222472 0 0.0
.text 2546069 2546069 0 0.0
bridge-app debug (read only) 2514373 2514373 0 0.0
(read/write) 129328 129328 0 0.0
.bss 49944 49944 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69552 69552 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 171656 171656 0 0.0
.text 2170469 2170469 0 0.0
chip-tool debug (read only) 12979665 12979665 0 0.0
(read/write) 695592 695592 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 659336 659336 0 0.0
.dynamic 608 608 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 623629 623629 0 0.0
.text 10738708 10738708 0 0.0
chip-tool-ipv6only arm64 (read only) 12263932 12263932 0 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570752 570752 0 0.0
.text 9920372 9920372 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2577989 2577989 0 0.0
(read/write) 126520 126520 0 0.0
.bss 47256 47256 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 70136 70136 0 0.0
.dynamic 624 624 0 0.0
.got 4800 4800 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 174376 174376 0 0.0
.text 2226325 2226325 0 0.0
lighting-app debug+rpc+ui (read only) 3240977 3240977 0 0.0
(read/write) 132112 132112 0 0.0
.bss 47936 47936 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 74680 74680 0 0.0
.dynamic 656 656 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 283060 283060 0 0.0
.text 2766194 2766194 0 0.0
lock-app debug (read only) 2653213 2653213 0 0.0
(read/write) 123464 123464 0 0.0
.bss 45856 45856 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204712 204712 0 0.0
.text 2275877 2275877 0 0.0
ota-provider-app debug (read only) 2206229 2206229 0 0.0
(read/write) 103608 103608 0 0.0
.bss 44496 44496 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 51888 51888 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 152808 152808 0 0.0
.text 1911973 1911973 0 0.0
ota-requestor-app debug (read only) 2373213 2373213 0 0.0
(read/write) 111304 111304 0 0.0
.bss 46864 46864 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56744 56744 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 156872 156872 0 0.0
.text 2066021 2066021 0 0.0
shell debug (read only) 2673993 2673993 0 0.0
(read/write) 140808 140808 0 0.0
.bss 58984 58984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 74760 74760 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 197202 197202 0 0.0
.text 2315010 2315010 0 0.0
thermostat-no-ble arm64 (read only) 2519156 2519156 0 0.0
(read/write) 142392 142392 0 0.0
.bss 53464 53464 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 560 560 0 0.0
.got 5424 5424 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 129256 129256 0 0.0
.text 2126628 2126628 0 0.0
tv-app debug (read only) 3308665 3308665 0 0.0
(read/write) 261224 261224 0 0.0
.bss 170976 170976 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79424 79424 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 220856 220856 0 0.0
.text 2891698 2891698 0 0.0
tv-casting-app debug (read only) 6801553 6801553 0 0.0
(read/write) 185552 185552 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 125184 125184 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 308684 308684 0 0.0
.text 6147938 6147938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495064 2495064 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457748 1457748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176356 1176356 0 0.0
bss 155563 155563 0 0.0
rodata 132756 132756 0 0.0
text 807284 807284 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436084 1436084 0 0.0
bss 135303 135303 0 0.0
rodata 228772 228772 0 0.0
text 777944 777944 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123464 1123464 0 0.0
bss 154757 154757 0 0.0
rodata 109752 109752 0 0.0
text 778220 778220 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840680 840680 0 0.0
(read/write) 1706636 1706636 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190108 190108 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1285336 1285336 0 0.0
.debug_aranges 128296 128296 0 0.0
.debug_frame 425812 425812 0 0.0
.debug_info 27010787 27010788 1 0.0
.debug_line 3761460 3761460 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2021763 2021763 0 0.0
.debug_rnglists 128096 128096 0 0.0
.debug_str 3640280 3640280 0 0.0
.heap 840680 840680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 716254 716254 0 0.0
.symtab 466336 466336 0 0.0
.text 1505588 1505588 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841440 841440 0 0.0
(read/write) 1648964 1648964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1280142 1280142 0 0.0
.debug_aranges 127768 127768 0 0.0
.debug_frame 428880 428880 0 0.0
.debug_info 26786852 26786851 -1 -0.0
.debug_line 3784161 3784161 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2014857 2014857 0 0.0
.debug_rnglists 127260 127260 0 0.0
.debug_str 3631982 3631982 0 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674942 674942 0 0.0
.symtab 451648 451648 0 0.0
.text 1448676 1448676 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1570596 1570596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1112592 1112592 0 0.0
.debug_aranges 117920 117920 0 0.0
.debug_frame 392116 392116 0 0.0
.debug_info 22308529 22308529 0 0.0
.debug_line 3347159 3347159 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1846371 1846371 0 0.0
.debug_rnglists 116889 116889 0 0.0
.debug_str 3437961 3437961 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 590995 590995 0 0.0
.symtab 414096 414096 0 0.0
.text 1378604 1378604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627100 1627100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1111608 1111608 0 0.0
.debug_aranges 118424 118424 0 0.0
.debug_frame 394208 394208 0 0.0
.debug_info 22488412 22488413 1 0.0
.debug_line 3343541 3343541 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1859798 1859798 0 0.0
.debug_rnglists 117345 117345 0 0.0
.debug_str 3452943 3452943 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 594996 594996 0 0.0
.symtab 416400 416400 0 0.0
.text 1407324 1407324 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1169632 1169632 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616732 616732 0 0.0
lock-app qpg6105+debug (read/write) 1139500 1139500 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586600 586600 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1001104 1001104 0 0.0
bss 97912 97912 0 0.0
text 680014 680016 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 937808 937816 8 0.0
bss 97004 97004 0 0.0
text 642580 642582 2 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 919076 919076 0 0.0
bss 99220 99220 0 0.0
text 635222 635226 4 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 847636 847636 0 0.0
bss 88904 88904 0 0.0
text 575448 575452 4 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 863932 863932 0 0.0
bss 89060 89060 0 0.0
text 590080 590076 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934400 934400 0 0.0
bss 97376 97376 0 0.0
text 652262 652264 2 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945812 945804 -8 -0.0
bss 101624 101624 0 0.0
text 659820 659816 -4 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1002676 1002668 -8 -0.0
bss 98940 98940 0 0.0
text 695974 695972 -2 -0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 902476 902476 0 0.0
bss 89556 89556 0 0.0
text 603940 603938 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870524 870524 0 0.0
bss 90176 90176 0 0.0
text 597546 597548 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853484 853484 0 0.0
bss 89024 89024 0 0.0
text 581470 581472 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840432 840432 0 0.0
bss 88824 88824 0 0.0
text 571746 571748 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836668 836668 0 0.0
bss 88744 88744 0 0.0
text 567458 567458 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868328 868328 0 0.0
bss 90448 90448 0 0.0
text 591794 591794 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864980 864980 0 0.0
bss 90868 90868 0 0.0
text 587482 587480 -2 -0.0

bzbarsky-apple
bzbarsky-apple reviewed May 16, 2023
View reviewed changes
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes May 17, 2023
View reviewed changes
src/darwin/Framework/CHIP/MTRDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDevice.mm Show resolved Hide resolved
@andy31415 andy31415 merged commit 2b605bc into project-chip:master May 18, 2023
@jtung-apple jtung-apple mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@jtung-apple jtung-apple

Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtung-apple @andy31415 @bzbarsky-apple