-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ExtractSubjectFromX509Cert() and ExtractIssuerFromX509Cert() Helper Functions #26588
Merged
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-subject
May 16, 2023
Merged
Implemented ExtractSubjectFromX509Cert() and ExtractIssuerFromX509Cert() Helper Functions #26588
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-subject
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t() Helper Function
PR #26588: Size comparison from 9352f86 to c5048ec Increases (13 builds for bl702, cc32xx, efr32, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, esp32, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 16, 2023
arkq
approved these changes
May 16, 2023
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
…t() Helper Function (project-chip#26588)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26426 and #26427
Note that the actual implementation is different from what is described in #26426 and #26427. The output was expected to point to the Subject/Issuer field in the certificate. Because of some crypto libraries unique implementations of the certificate parsing logic this implementation copies values into the buffer provided by the caller