-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zcl_clusters for python #26668
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:use_zcl_clusters_for_python
May 19, 2023
Merged
Use zcl_clusters for python #26668
andy31415
merged 3 commits into
project-chip:master
from
andy31415:use_zcl_clusters_for_python
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 18, 2023 19:50
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
May 18, 2023 19:50
bzbarsky-apple
approved these changes
May 18, 2023
PR #26668: Size comparison from 0a635ca to 6847e9d Increases (1 build for cc32xx)
Decreases (1 build for qpg)
Full report (6 builds for cc32xx, linux, mbed, qpg)
|
PR #26668: Size comparison from 0a635ca to 778f3e2 Increases (9 builds for bl702, cc32xx, psoc6, telink)
Decreases (10 builds for bl602, efr32, esp32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make python not depend on
.zap
file.Tested via codegen via:
This found that the expansion of structures did not work well as it would expand to the same name as structs internally, which seems to break nested structs and arrays. I updated to never linearly expand, however I will rely on CI tests to validate if something is obviously broken by this.