-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Do not include the pre/post processing to the test… #26680
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_PrePostProcessingNotPartOfTimeout
May 19, 2023
Merged
[matter_yamltests] Do not include the pre/post processing to the test… #26680
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_PrePostProcessingNotPartOfTimeout
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 19, 2023 09:15
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 19, 2023 09:15
PR #26680: Size comparison from e75e729 to 579d40e Increases (10 builds for bl702, cc32xx, esp32, k32w, psoc6, telink)
Decreases (7 builds for bl602, efr32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 19, 2023
tcarmelveilleux
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… timeout
Problem
The pre/post processing chunks in the python yaml runner which may be used to setup/teardown some parts of the stack are actually accounted during the test timeout. This is an issue for long tasks such as connecting to a remote server.
This PR ensure that pre/post processing are not part of the timeout.
fix #26660