-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LTNE (Local Temperature Not Exposed) feature in Therm… #26686
Merged
andy31415
merged 6 commits into
project-chip:master
from
huangzh142:feature_LTNE_thermostat_cluster
May 24, 2023
Merged
Add support for LTNE (Local Temperature Not Exposed) feature in Therm… #26686
andy31415
merged 6 commits into
project-chip:master
from
huangzh142:feature_LTNE_thermostat_cluster
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26686: Size comparison from e75e729 to ba43565 Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
May 19, 2023 12:36
PR #26686: Size comparison from e75e729 to cef9b35 Increases above 0.2%:
Increases (26 builds for bl602, bl702, cc32xx, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
huangzh142
force-pushed
the
feature_LTNE_thermostat_cluster
branch
from
May 20, 2023 08:06
cef9b35
to
c0a4f70
Compare
PR #26686: Size comparison from bfa0580 to d884b45 Increases above 0.2%:
Increases (23 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for cc32xx, efr32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
andy31415
reviewed
May 23, 2023
bzbarsky-apple
approved these changes
May 23, 2023
andy31415
approved these changes
May 24, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 25, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 25, 2023
bzbarsky-apple
added a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for LTNE (Local Temperature Not Exposed) feature in Thermostat Cluster