-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency of test codegen on controller-clusters.zapt state. #26703
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:zap-test-codegen-no-dep-on-controller-clusters
May 23, 2023
Merged
Remove dependency of test codegen on controller-clusters.zapt state. #26703
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:zap-test-codegen-no-dep-on-controller-clusters
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
May 19, 2023 20:01
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 19, 2023 20:01
PR #26703: Size comparison from f55fa96 to 14e754d Increases (1 build for psoc6)
Decreases (7 builds for bl602, bl702, nrfconnect, psoc6)
Full report (33 builds for bl602, bl702, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
force-pushed
the
zap-test-codegen-no-dep-on-controller-clusters
branch
from
May 19, 2023 20:55
14e754d
to
696284f
Compare
PR #26703: Size comparison from 149b756 to 696284f Increases (11 builds for esp32, k32w, psoc6, telink)
Decreases (11 builds for bl602, bl702, efr32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
zap-test-codegen-no-dep-on-controller-clusters
branch
from
May 20, 2023 03:35
696284f
to
03e85f8
Compare
PR #26703: Size comparison from bfa0580 to 03e85f8 Increases (14 builds for bl602, bl702, psoc6, telink)
Decreases (8 builds for efr32, esp32, k32w, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Depends on project-chip/zap#1035 to actually ignore that state.
bzbarsky-apple
force-pushed
the
zap-test-codegen-no-dep-on-controller-clusters
branch
from
May 22, 2023 16:54
03e85f8
to
28f730b
Compare
PR #26703: Size comparison from 44c7faf to 28f730b Increases (7 builds for efr32, esp32, nrfconnect, psoc6, telink)
Decreases (16 builds for bl602, bl702, cc32xx, efr32, k32w, psoc6, qpg, telink)
Full report (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
May 22, 2023
yufengwangca
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on project-chip/zap#1035 to actually ignore that state.