-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add cluster Btn in chiptool (Opcred, administratorCommissioning) #26782
Merged
andy31415
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_commissioning_cluster_btn
May 25, 2023
Merged
[Android] Add cluster Btn in chiptool (Opcred, administratorCommissioning) #26782
andy31415
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_commissioning_cluster_btn
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no and
ksperling-apple
May 24, 2023 05:47
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
May 24, 2023 05:48
PR #26782: Size comparison from 75bd5af to 007a54b Increases (2 builds for cc32xx, nrfconnect)
Decreases (3 builds for nrfconnect, qpg)
Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)
|
PR #26782: Size comparison from 75bd5af to 8043151 Increases (9 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (10 builds for cyw30739, efr32, esp32, psoc6, telink)
Full report (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 25, 2023
...HIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/MultiAdminClientFragment.kt
Outdated
Show resolved
Hide resolved
yunhanw-google
approved these changes
May 25, 2023
yunhanw-google
approved these changes
May 25, 2023
joonhaengHeo
force-pushed
the
add_commissioning_cluster_btn
branch
from
May 25, 2023 06:24
d96e05f
to
eacd2d6
Compare
PR #26782: Size comparison from 9f43988 to eacd2d6 Increases (15 builds for bl602, bl702, cc32xx, cyw30739, esp32, psoc6, telink)
Decreases (6 builds for efr32, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some command, read attribute button.