-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python tests] decode shell output as UTF-8 #26783
Merged
andy31415
merged 1 commit into
project-chip:master
from
agners:scripts-decode-output-as-utf-8
May 24, 2023
Merged
[python tests] decode shell output as UTF-8 #26783
andy31415
merged 1 commit into
project-chip:master
from
agners:scripts-decode-output-as-utf-8
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If tests are run on a platform which is returning special characters (e.g. date with months which contain an umlaut) runnig the test fails: ``` File "/home/sag/projects/project-chip/connectedhomeip/./scripts/tests/run_python_test.py", line 95, in main print(subprocess.check_output(["ls -l"], shell=True).decode('us-ascii')) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1553: ordinal not in range(128) ``` Decode the output using UTF-8 by default.
PR #26783: Size comparison from d34a250 to 26fa1b1 Increases (14 builds for bl602, bl702, cc32xx, psoc6, qpg, telink)
Decreases (5 builds for efr32, esp32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
May 24, 2023
andy31415
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tests are run on a platform which is returning special characters (e.g. date with months which contain an umlaut) runnig the test fails:
Decode the output using UTF-8 by default.