-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland Use controller exception in Java controller #26802
Merged
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/improve_java_controller2
May 25, 2023
Merged
Reland Use controller exception in Java controller #26802
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/improve_java_controller2
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 24, 2023 17:16
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 24, 2023 17:16
PR #26802: Size comparison from bf95967 to 89979f1 Increases (13 builds for bl702, cc32xx, esp32, psoc6, telink)
Decreases (12 builds for bl602, cyw30739, efr32, esp32, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
changed the title
Reland Use controller exception in Java controller
[debugging]Reland Use controller exception in Java controller
May 24, 2023
PR #26802: Size comparison from bf95967 to ec9caa7 Increases (5 builds for bl702, cc32xx, psoc6)
Decreases (5 builds for bl602, efr32, esp32, nrfconnect, psoc6)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/improve_java_controller2
branch
from
May 24, 2023 20:22
ec9caa7
to
95a4a50
Compare
yunhanw-google
changed the title
[debugging]Reland Use controller exception in Java controller
Reland Use controller exception in Java controller
May 24, 2023
PR #26802: Size comparison from 6ce2412 to 95a4a50 Increases (9 builds for bl602, cc32xx, efr32, telink)
Decreases (9 builds for bl702, cyw30739, efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Use controller exception in Java controller so that the exception can have the error code inside when passing from C++ to Java/Kotlin
--Matter error is uint32_t, we should cast it to long in Java, fix this issue across.