-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zcl cluster for chip client callbacks #26952
Merged
andy31415
merged 11 commits into
project-chip:master
from
andy31415:use_zcl_cluster_for_chip_client_callbacks
Jun 2, 2023
Merged
Use zcl cluster for chip client callbacks #26952
andy31415
merged 11 commits into
project-chip:master
from
andy31415:use_zcl_cluster_for_chip_client_callbacks
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 30, 2023 15:23
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 30, 2023 15:23
PR #26952: Size comparison from 2205eb6 to 3a62a60 Increases (4 builds for bl702, nrfconnect)
Decreases (1 build for nrfconnect)
Full report (14 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect)
|
turon
approved these changes
May 30, 2023
PR #26952: Size comparison from ff79792 to 1e220c9 Increases (11 builds for cc32xx, cyw30739, esp32, psoc6, telink)
Decreases (7 builds for efr32, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
May 30, 2023
robszewczyk
approved these changes
May 30, 2023
bzbarsky-apple
requested changes
May 31, 2023
bzbarsky-apple
approved these changes
Jun 1, 2023
PR #26952: Size comparison from 5d913c9 to dc39766 Increases (16 builds for bl702, nrfconnect, psoc6, telink)
Decreases (22 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop depending on
.zap
file (i.e. manual cluster enable/disable) for generating CHIPClientCallbacks.h.It turns out that CHIPClientCallbacks.h is only used for java.
Updated this file to move to java-specific codegen instead of app-specific one.