-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] LEDs & Buttons DTS improvements #27034
Merged
andy31415
merged 4 commits into
project-chip:master
from
s07641069:telink_leds_buttons_improvements
Jun 3, 2023
Merged
[Telink] LEDs & Buttons DTS improvements #27034
andy31415
merged 4 commits into
project-chip:master
from
s07641069:telink_leds_buttons_improvements
Jun 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
June 2, 2023 13:11
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple and
xylophone21
June 2, 2023 13:11
PR #27034: Size comparison from d7dbc7a to e4f9016 Decreases (1 build for cc32xx)
Full report (5 builds for cc32xx, mbed, nrfconnect)
|
PR #27034: Size comparison from d7dbc7a to 2684b39 Increases (8 builds for bl602, cc32xx, cyw30739, telink)
Decreases (20 builds for bl702, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping.
andy31415
approved these changes
Jun 3, 2023
PR #27034: Size comparison from 83ecf9c to 6027824 Increases (8 builds for esp32, nrfconnect, psoc6, telink)
Decreases (23 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27034: Size comparison from 5711d2f to 516810d Increases (10 builds for cc32xx, cyw30739, esp32, psoc6, telink)
Decreases (21 builds for bl602, k32w, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview