-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] The error is not reported over websocket when a read/subs… #27040
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipToolPy_GeneralReadError
Jun 16, 2023
Merged
[chip-tool] The error is not reported over websocket when a read/subs… #27040
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipToolPy_GeneralReadError
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
June 2, 2023 14:57
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 2, 2023 14:57
PR #27040: Size comparison from e19d9d8 to 5ebc128 Increases (11 builds for bl702, esp32, linux, psoc6, telink)
Decreases (13 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2023
vivien-apple
force-pushed
the
ChipToolPy_GeneralReadError
branch
from
June 5, 2023 07:50
5ebc128
to
ed82596
Compare
PR #27040: Size comparison from 275341e to ed82596 Increases (8 builds for bl702, linux, psoc6, telink)
Decreases (12 builds for bl602, bl702, k32w, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jun 5, 2023
andy31415
reviewed
Jun 5, 2023
…cribe action has a global error
vivien-apple
force-pushed
the
ChipToolPy_GeneralReadError
branch
from
June 8, 2023 07:56
ed82596
to
3e3dafe
Compare
PR #27040: Size comparison from d4c7d47 to 3e3dafe Increases above 0.2%:
Increases (8 builds for esp32, linux, psoc6, telink)
Decreases (18 builds for bl602, bl702, cc32xx, esp32, k32w, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cribe action has a global error
Problem
The IDM tests targeting attribute reads sometimes expects an
INVALID_ACTION
. This generic error is not carried over WebSocket.