-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete dynamic bridge example #27077
Merged
andy31415
merged 6 commits into
project-chip:master
from
andy31415:delete_dynamic_bridge
Jun 5, 2023
Merged
Delete dynamic bridge example #27077
andy31415
merged 6 commits into
project-chip:master
from
andy31415:delete_dynamic_bridge
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
github
integrations
scripts
workflows
labels
Jun 5, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
June 5, 2023 14:55
pullapprove
bot
requested review from
xylophone21,
younghak-hwang and
yunhanw-google
June 5, 2023 14:55
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
github
integrations
scripts
workflows
labels
Jun 5, 2023
bzbarsky-apple
approved these changes
Jun 5, 2023
PR #27077: Size comparison from 5165007 to a024790 Increases (3 builds for nrfconnect, psoc6)
Decreases (5 builds for bl602, bl702, k32w, psoc6)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
cecille
approved these changes
Jun 5, 2023
PR #27077: Size comparison from cd898c4 to c40f069 Decreases (1 build for nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
@andy31415 What are your recommendations for mapping 3rd part devices to the Matter side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
examples
github
integrations
lib
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic bridge is not maintained/used and it seems to periodically create compile errors. Since it uses std a lot (std::vector, std::string), its interoperability with embedded-friendly constructs in
DataModel
is non-trivial to maintain.Delete example without a maintainer.
Likely fixes #26208 by making it obsolete (no more dynamic bridge app)