-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/scene save efs dynamical array #27078
Merged
lpbeliveau-silabs
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/SceneSaveEFS_dynamical_array
Jun 5, 2023
Merged
Bugfix/scene save efs dynamical array #27078
lpbeliveau-silabs
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/SceneSaveEFS_dynamical_array
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
June 5, 2023 16:14
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 5, 2023 16:14
PR #27078: Size comparison from 13cd63a to 82b1a6f Increases (10 builds for bl702, cyw30739, linux, nrfconnect, psoc6, qpg)
Decreases (8 builds for bl602, cc32xx, cyw30739, psoc6)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
…th expected results from TestSceneTable
PR #27078: Size comparison from 13cd63a to f7dbf3f Increases above 0.2%:
Increases (30 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27078: Size comparison from 13cd63a to 04394f8 Increases above 0.2%:
Increases (10 builds for bl602, bl702, cc32xx, linux, nrfconnect, qpg)
Decreases (5 builds for bl602, bl702, nrfconnect)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
bzbarsky-apple
approved these changes
Jun 5, 2023
jmartinez-silabs
approved these changes
Jun 5, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #27078: Size comparison from 13cd63a to 939d1ca Increases above 0.2%:
Increases (28 builds for bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intitial cluster buffer needs to be big enough for all the clusters on the endpoint, otherwise this will fail. InsertFieldSet will return an out of memory error if the user tries to add more field sets that supported.