-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename HasEventWildcard to IsWildcardPath. #27105
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:rename-event-wildcard
Jun 7, 2023
Merged
Rename HasEventWildcard to IsWildcardPath. #27105
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:rename-event-wildcard
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
June 6, 2023 15:14
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 6, 2023 15:14
PR #27105: Size comparison from 77a92d4 to 973dd5c Increases (7 builds for bl702, cc32xx, cyw30739, psoc6, qpg)
Decreases (9 builds for bl602, bl702, cc32xx, cyw30739, psoc6)
Full report (28 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
This is checking for wildcard endpoints/clusters too, so HasEventWildcard is pretty misleading.
bzbarsky-apple
force-pushed
the
rename-event-wildcard
branch
from
June 6, 2023 16:17
973dd5c
to
470c4bb
Compare
PR #27105: Size comparison from 2d80c43 to 470c4bb Increases (6 builds for esp32, nrfconnect, telink)
Decreases (13 builds for bl702, cc32xx, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 6, 2023
tcarmelveilleux
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is checking for wildcard endpoints/clusters too, so HasEventWildcard is pretty misleading.