-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] docs: install esptool for idf v5.x and above and disable "chip_build_tests" by default #27141
Merged
woody-apple
merged 5 commits into
project-chip:master
from
shubhamdp:esp32_esptool_in_docs
Jun 8, 2023
Merged
[ESP32] docs: install esptool for idf v5.x and above and disable "chip_build_tests" by default #27141
woody-apple
merged 5 commits into
project-chip:master
from
shubhamdp:esp32_esptool_in_docs
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lboue Please take a look! |
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jun 8, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
June 8, 2023 05:20
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 8, 2023 05:20
shubhamdp
force-pushed
the
esp32_esptool_in_docs
branch
from
June 8, 2023 05:48
3e3a3e1
to
509465b
Compare
shubhamdp
changed the title
[ESP32] docs: install esptool for idf v5.x and above
[ESP32] docs: install esptool for idf v5.x and above and
Jun 8, 2023
shubhamdp
changed the title
[ESP32] docs: install esptool for idf v5.x and above and
[ESP32] docs: install esptool for idf v5.x and above and disable "chip_build_tests" by default
Jun 8, 2023
PR #27141: Size comparison from d4c7d47 to 509465b Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #27141: Size comparison from d4c7d47 to e46fc3a Increases (8 builds for nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, cc32xx, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27141: Size comparison from d4c7d47 to 7f97336 Increases (7 builds for nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, esp32, k32w, mbed, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
documentation
Improvements or additions to documentation
examples
fast track
review - pending
test driver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27060
Also, ESP32 examples were building examples with "chip_build_tests" set to "true", not needed, disabled them. May be builds would get a bit faster.