-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Move the openthread platform config file to examples #27162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27162: Size comparison from 530349a to a54fd34 Increases (5 builds for cyw30739, esp32, k32w, psoc6, telink)
Decreases (11 builds for bl602, bl702, psoc6, qpg, telink)
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 9, 2023
chshu
approved these changes
Jun 12, 2023
chshu
force-pushed
the
esp32/move_out_thread_config
branch
from
June 12, 2023 09:52
a54fd34
to
a1de9bb
Compare
auto-merge was automatically disabled
June 12, 2023 09:57
Head branch was pushed to by a user without write access
wqx6
force-pushed
the
esp32/move_out_thread_config
branch
from
June 12, 2023 09:57
a1de9bb
to
e93dff3
Compare
wqx6
force-pushed
the
esp32/move_out_thread_config
branch
from
June 12, 2023 10:01
e93dff3
to
62ee2df
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
arkq,
cecille,
chrisdecenzo,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
electrocucaracha,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
June 12, 2023 10:01
pullapprove
bot
requested review from
kcoppock,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
xylophone21,
younghak-hwang and
yunhanw-google
June 12, 2023 10:01
PR #27162: Size comparison from 40fb7c2 to 62ee2df Increases (11 builds for bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc32xx, k32w, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
wqx6
added a commit
to wqx6/connectedhomeip
that referenced
this pull request
Jun 13, 2023
chshu
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to move openthread platform config file to examples so that we can config it in example instead of changing the platform codes.