Reduce number of replies on MinMds query processing. #27183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UDP packets are received on every listening interface, resulting in single queries being multipled by the interface count and this causes more packets than expected being generated. This change will only process queries that are originating from the same interface that the mdns endpoint is bound to.
|
PR #27183: Size comparison from 40fb7c2 to ed37d0d Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #27183: Size comparison from 40fb7c2 to b57c0c2 Increases (34 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
Marking as ready for review as this reduces number of replies in minmdns. I am still wondering if maybe there is an update potential for minmdns to use less udp sockets and listening ports as I would expect addr_any to cover listening over more interfaces (the existing behavior seems to cover that). |
tcarmelveilleux
approved these changes
Jun 13, 2023
|
obsolete after #27219 |
|
Re-opened as the other PR seems to have issues on OpenIOT. The error of |
|
PR #27183: Size comparison from 4e9d26e to b57c0c2 Increases (33 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl702, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
can we cherry pick this PR on v1.1-branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDP packets are received on every listening interface, resulting in single queries being multipled by the interface count and this causes more packets than expected being generated.
This change will only process queries that are originating from the same interface that the mdns endpoint is bound to.