examples/lock-app/esp32: synchronize buttons to matter #27270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
PR #27270: Size comparison from 5efdd31 to 74a6bff Increases (1 build for nrfconnect)
Decreases (3 builds for bl602, cc32xx)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
Appears to have been badly copy/pasted from other examples perhaps. Without this update call, pushing the button locally will update the LEDs and print the messages, but will not update the matter cluster state. Signed-off-by: Karl Palsson <karlp@tweak.au>
|
PR #27270: Size comparison from 82438f5 to 6b003a4 Increases (5 builds for cc32xx, telink)
Decreases (13 builds for bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 15, 2023
andy31415
approved these changes
Jun 19, 2023
karlp
added a commit
to karlp/connectedhomeip
that referenced
this pull request
Aug 29, 2023
…27270) Appears to have been badly copy/pasted from other examples perhaps. Without this update call, pushing the button locally will update the LEDs and print the messages, but will not update the matter cluster state. Signed-off-by: Karl Palsson <karlp@tweak.au>
karlp
added a commit
to karlp/connectedhomeip
that referenced
this pull request
Sep 1, 2023
Fixes: a0cb270 project-chip#27270 The earlier fix had been developed against matter 1.0 branch, so the incorrect style of scheduling to avoid lock checking was used. Use the same style (via PlatformMgr, not SystemLayer) as all other examples. Signed-off-by: Karl Palsson <karlp@tweak.au> FIXME: this fixes the crash, but we're still not synchronizing to HASS anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to have been badly copy/pasted from other examples perhaps. Without this update call, pushing the button locally will update the LEDs and print the messages, but will not update the matter cluster state.