-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinMDNS: reduce amount of data in the mdns advertising packets (and make it more RFC compliant) #27274
Merged
andy31415
merged 11 commits into
project-chip:master
from
andy31415:do_not_duplicate_packet_content
Jun 19, 2023
Merged
MinMDNS: reduce amount of data in the mdns advertising packets (and make it more RFC compliant) #27274
andy31415
merged 11 commits into
project-chip:master
from
andy31415:do_not_duplicate_packet_content
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…answers instead of additional records
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
June 15, 2023 17:10
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 15, 2023 17:10
andy31415
changed the title
Reduce amount of data in the mdns advertising packets in minmdns
MinMDNS: reduce amount of data in the mdns advertising packets (and make it more RFC compliant)
Jun 15, 2023
PR #27274: Size comparison from dea6db7 to 8a12b03 Increases (29 builds for bl602, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (11 builds for nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jun 15, 2023
…st' 'AnnounceBroadcast'
PR #27274: Size comparison from dea6db7 to 3365912 Increases above 0.2%:
Increases (3 builds for mbed, nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
PR #27274: Size comparison from 48c2043 to 6e7a924 Increases (31 builds for bl602, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 16, 2023
can we cherry pick this PR on v1.1-branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinMDNS translates a tree-like structure into mdns packets, so its data reports are a bit off (and overly large) from the spec. Specifically it showed dnssd browsing data at bootup and also duplicated IP addresses (visible in multi admin scenarios).
Made the following changes:
Answers
only (as opposed to mix of answers and additional records) as per RFC_services._dns-sd._udp.local
during startup advertisements