-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin-framework-tool] Add discover module to scan and list the discovered commissionable devices over BLE and Mdns #27318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be added when discovered over the network
PR #27318: Size comparison from f5c4621 to 5f87c23 Increases (10 builds for bl602, bl702, linux, nrfconnect, psoc6, qpg)
Decreases (1 build for esp32)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
…eviceControllerFactory::stopScan [matter framework] Add MTRDeviceController::setupCommissiongSessionWithDiscoveredDevice
…overed commissionable devices over BLE and Mdns [darwin-framework-tool] Add pairing by-index command to commission a discovered device
vivien-apple
force-pushed
the
Darwin_Discover
branch
from
June 19, 2023 12:02
5f87c23
to
9c0beef
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
June 19, 2023 12:03
PR #27318: Size comparison from f5c4621 to 9c0beef Increases (20 builds for bl602, bl702, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…orm/Dnssd.h from interfaceId to interface
PR #27318: Size comparison from f5c4621 to 4d7a52d Increases (13 builds for bl602, bl702, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc32xx, cyw30739, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 20, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 26, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 26, 2023
#27483 tracks most of the above comments; the remaining ones are #27318 (comment) and #27318 (comment) |
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 27, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 27, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 27, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 27, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 3, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 3, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 3, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 3, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 4, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 4, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 4, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements
discover start
,discover stop
,discover list
as well aspairing by-index
forDarwin-framework-tool
and usingMatter.framework
Similarly to the
chip-tool
implementation it allows to listen for commissionable device over the networks and commission one if needed.