-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Window-app refactor #27390
[Silabs] Window-app refactor #27390
Conversation
Fixed Window App Refactor
Fix WiFi build
PR #27390: Size comparison from 90cfc52 to 4b74c32 Increases above 0.2%:
Increases (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for efr32, k32w)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I see you created a specific zap config for the app now and before we were using the common window-app zap file. Is there any difference in this new zap compared to the common one? The ci does repo at least some issue in it with the code-lint
Seems to me like the PR was started before @lpbeliveau-silabs added the scenes tables, Should sync with him for the appropriated fix. @andygallay-silabs |
Window-app refactor to use Silabs base application for examples. Tested with chip-tool on BRD4187C.