-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unit tests for QRCodeOnboardingPayload #27587
Conversation
PR #27587: Size comparison from 7ae5919 to f96933d Increases (11 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (7 builds for esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27587: Size comparison from 0522ef0 to 5927edc Increases (11 builds for bl602, cc32xx, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702l, cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27587: Size comparison from fcf37c2 to 6639398 Increases (14 builds for bl702, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for bl702l, cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/controller/java/src/chip/onboardingpayload/QRCodeOnboardingPayloadParser.kt
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/onboardingpayload/QRCodeOnboardingPayloadParser.kt
Outdated
Show resolved
Hide resolved
PR #27587: Size comparison from f7eff71 to fa00ad3 Increases (8 builds for bl702, bl702l, cc32xx, psoc6, telink)
Decreases (8 builds for bl602, bl702, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27587: Size comparison from 2f875c7 to 0497742 Increases (8 builds for bl602, nrfconnect, telink)
Decreases (13 builds for bl602, bl702, cyw30739, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@yufengwangca need fixes for detekt static code analysis. For constants I believe tests can have hardcoded numbers so we can update For the rest please check on a case by case basis. |
PR #27587: Size comparison from c80c789 to e738f56 Increases (2 builds for bl702l, qpg)
Decreases (2 builds for bl602, bl702)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #27587: Size comparison from f1c6c4a to 4f7dd01 Increases (2 builds for cc32xx, nrfconnect)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #27587: Size comparison from f1c6c4a to 0285923 Increases above 0.2%:
Increases (5 builds for efr32, nrfconnect)
Decreases (3 builds for bl702, efr32)
Full report (21 builds for bl602, bl702, bl702l, cc32xx, efr32, k32w, linux, mbed, nrfconnect, qpg)
|
PR #27587: Size comparison from a2a3712 to 05d4bc7 Increases (11 builds for bl702l, cyw30739, k32w, nrfconnect, qpg, telink)
Decreases (13 builds for bl602, bl702, cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Implement unit tests for QRCodeOnboardingPayloadGenerator and QRCodeOnboardingPayloadParser, and add unit test to CI