Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump third_party/pigweed/repo from 4e9bb2b to ee4e09c #27597

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Bump third_party/pigweed/repo from 4e9bb2b to ee4e09c #27597

merged 2 commits into from
Jul 7, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023

Bumps third_party/pigweed/repo from 4e9bb2b to ee4e09c.

Commits
  • ee4e09c roll: host_tools
  • d2a3765 roll: sysroot
  • f4dd605 zephyr: Add Zephyr SDK to the Zephyr package
  • 114d417 pw_sys_io: Doxygenify WriteLine()
  • 4037d86 pw_log_zephyr: Add EOT character to help with detokenizing on Zephyr
  • 1bd7446 pw_digital_io: Doxygenify the state methods
  • b6c2ff1 pw_digital_io: Doxygenify the provides_* methods
  • d851dcb pw_system: Move snapshot proto call to namespace
  • 148e931 pw_build: Forward Python deps for pw_python_distributions
  • d531598 pw_toolchain: Include cross reference table in map files
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump third_party/pigweed/repo from 4e9bb2b to ee4e09c
f891907 
Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `4e9bb2b` to `ee4e09c`.
- [Commits](google/pigweed@4e9bb2b...ee4e09c)

---
updated-dependencies:
- dependency-name: third_party/pigweed/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added external dependency Bugs that require changes in third party projects. submodules Pull requests that update Submodules code labels Jul 3, 2023
@pullapprove pullapprove bot requested a review from xylophone21 July 3, 2023 08:41
@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited
Loading

PR #27597: Size comparison from 7ae5919 to f891907

Increases (4 builds for qpg, telink)
platform target config section 7ae5919 f891907 change % change
qpg lock-app qpg6105+debug (read/write) 1129992 1130000 8 0.0
.text 576836 576844 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 877964 877972 8 0.0
text 600636 600638 2 0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 979868 979876 8 0.0
text 689270 689274 4 0.0
ota-requestor-app tlsr9518adk80d text 607854 607856 2 0.0
Decreases (3 builds for nrfconnect, telink)
platform target config section 7ae5919 f891907 change % change
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 753796 753792 -4 -0.0
telink lighting-app-shell tlsr9518adk80d text 746790 746788 -2 -0.0
thermostat tlsr9518adk80d (read/write) 896336 896328 -8 -0.0
text 617162 617160 -2 -0.0
Full report (36 builds for k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 7ae5919 f891907 change % change
k32w contact k32w0+release (read only) 586132 586132 0 0.0
(read/write) 90104 90104 0 0.0
.bss 66108 66108 0 0.0
.data 2168 2168 0 0.0
.text 585596 585596 0 0.0
light k32w0+release (read only) 584836 584836 0 0.0
(read/write) 89752 89752 0 0.0
.bss 65772 65772 0 0.0
.data 2156 2156 0 0.0
.text 584300 584300 0 0.0
lock k32w0+release (read only) 557420 557420 0 0.0
(read/write) 87560 87560 0 0.0
.bss 63636 63636 0 0.0
.data 2100 2100 0 0.0
.text 556884 556884 0 0.0
linux all-clusters-app debug (read only) 3277789 3277789 0 0.0
(read/write) 159552 159552 0 0.0
.bss 59776 59776 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 91112 91112 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 231720 231720 0 0.0
.text 2854117 2854117 0 0.0
all-clusters-minimal-app debug (read only) 3055701 3055701 0 0.0
(read/write) 146504 146504 0 0.0
.bss 58176 58176 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79800 79800 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224200 224200 0 0.0
.text 2644645 2644645 0 0.0
bridge-app debug (read only) 2524253 2524253 0 0.0
(read/write) 129960 129960 0 0.0
.bss 50296 50296 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172712 172712 0 0.0
.text 2178405 2178405 0 0.0
chip-tool debug (read only) 18135345 18135345 0 0.0
(read/write) 842000 842000 0 0.0
.bss 93528 93528 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 736016 736016 0 0.0
.dynamic 624 624 0 0.0
.got 5848 5848 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 763753 763753 0 0.0
.text 15570035 15570035 0 0.0
lighting-app debug+rpc+ui (read only) 5206697 5206697 0 0.0
(read/write) 220680 220680 0 0.0
.bss 117248 117248 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 91048 91048 0 0.0
.dynamic 672 672 0 0.0
.got 5872 5872 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 328852 328852 0 0.0
.text 4638739 4638739 0 0.0
lock-app debug (read only) 2616949 2616949 0 0.0
(read/write) 117360 117360 0 0.0
.bss 45376 45376 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 64024 64024 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200200 200200 0 0.0
.text 2251781 2251781 0 0.0
ota-provider-app debug (read only) 2213437 2213437 0 0.0
(read/write) 103952 103952 0 0.0
.bss 44560 44560 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52184 52184 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153832 153832 0 0.0
.text 1917269 1917269 0 0.0
ota-requestor-app debug (read only) 2382437 2382437 0 0.0
(read/write) 111744 111744 0 0.0
.bss 47024 47024 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 57040 57040 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157928 157928 0 0.0
.text 2073301 2073301 0 0.0
shell debug (read only) 2813753 2813753 0 0.0
(read/write) 147968 147968 0 0.0
.bss 58728 58728 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 199922 199922 0 0.0
.text 2445906 2445906 0 0.0
tv-app debug (read only) 3319249 3319249 0 0.0
(read/write) 261856 261856 0 0.0
.bss 171264 171264 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79776 79776 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222520 222520 0 0.0
.text 2899730 2899730 0 0.0
tv-casting-app debug (read only) 9312033 9312033 0 0.0
(read/write) 221712 221712 0 0.0
.bss 52096 52096 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 161296 161296 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 330588 330588 0 0.0
.text 8547058 8547058 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2515040 2515040 0 0.0
.bss 216312 216312 0 0.0
.data 5152 5152 0 0.0
.text 1477724 1477724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1213404 1213404 0 0.0
bss 154985 154985 0 0.0
rodata 138144 138144 0 0.0
text 841204 841204 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1316244 1316244 0 0.0
bss 138311 138311 0 0.0
rodata 133432 133432 0 0.0
text 753796 753792 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1151196 1151196 0 0.0
bss 153481 153481 0 0.0
rodata 111408 111408 0 0.0
text 807212 807212 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1172400 1172400 0 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 619240 619240 0 0.0
lock-app qpg6105+debug (read/write) 1129992 1130000 8 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 576836 576844 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1037840 1037840 0 0.0
bss 97900 97900 0 0.0
text 710502 710502 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964424 964424 0 0.0
bss 96280 96280 0 0.0
text 667786 667786 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929940 929940 0 0.0
bss 100312 100312 0 0.0
text 642838 642838 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861648 861648 0 0.0
bss 89972 89972 0 0.0
text 586010 586010 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877964 877972 8 0.0
bss 90140 90140 0 0.0
text 600636 600638 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 968496 968496 0 0.0
bss 98652 98652 0 0.0
text 681750 681750 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 979868 979876 8 0.0
bss 102900 102900 0 0.0
text 689270 689274 4 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1037980 1037980 0 0.0
bss 100208 100208 0 0.0
text 726640 726640 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1069344 1069344 0 0.0
bss 111292 111292 0 0.0
text 746790 746788 -2 -0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916760 916760 0 0.0
bss 90636 90636 0 0.0
text 614680 614680 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884248 884248 0 0.0
bss 91248 91248 0 0.0
text 607854 607856 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867248 867248 0 0.0
bss 90104 90104 0 0.0
text 591772 591772 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854268 854268 0 0.0
bss 89904 89904 0 0.0
text 582114 582114 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850416 850416 0 0.0
bss 89812 89812 0 0.0
text 577744 577744 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896336 896328 -8 -0.0
bss 90348 90348 0 0.0
text 617162 617160 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 891708 891708 0 0.0
bss 90640 90640 0 0.0
text 612082 612082 0 0.0

@bzbarsky-apple
Copy link
Contributor

OK, so this specific darwin job is being built with the pigweed clang, not system clang, which is why the pigweed roll matters here, because it has "-clang" in the variant name.

The compile failure is:

connectedhomeip/src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.mm:30:105: error: format specifies type 'unsigned short' but the argument has type 'chip::Credentials::AttestationVerificationResult' [-Werror,-Wformat]
   30 |             "MTRDeviceAttestationDelegateBridge::OnDeviceAttestationFailed completed with result: %hu", attestationResult);
      |                                                                                                   ~~~   ^~~~~~~~~~~~~~~~~
      |                                                                                                   %hu

@bzbarsky-apple
Copy link
Contributor

This looks like it fixes the compile issue:

diff --git a/src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.mm b/src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.mm
index b9179185f9..454ca4556b 100644
--- a/src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.mm
+++ b/src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.mm
@@ -21,13 +21,15 @@
 #import "MTRLogging_Internal.h"
 #import "NSDataSpanConversion.h"
 
+#include <lib/support/TypeTraits.h>
+
 void MTRDeviceAttestationDelegateBridge::OnDeviceAttestationCompleted(chip::Controller::DeviceCommissioner * deviceCommissioner,
     chip::DeviceProxy * device, const chip::Credentials::DeviceAttestationVerifier::AttestationDeviceInfo & info,
     chip::Credentials::AttestationVerificationResult attestationResult)
 {
     dispatch_async(mQueue, ^{
-        MTR_LOG_DEFAULT(
-            "MTRDeviceAttestationDelegateBridge::OnDeviceAttestationFailed completed with result: %hu", attestationResult);
+        MTR_LOG_DEFAULT("MTRDeviceAttestationDelegateBridge::OnDeviceAttestationFailed completed with result: %hu",
+            chip::to_underlying(attestationResult));
 
         mResult = attestationResult;

@github-actions github-actions bot added the darwin label Jul 7, 2023
@mergify mergify bot merged commit 3133a00 into master Jul 7, 2023
@mergify mergify bot deleted the dependabot/submodules/third_party/pigweed/repo-ee4e09c branch July 7, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin external dependency Bugs that require changes in third party projects. fast track review - pending submodules Pull requests that update Submodules code
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @andy31415