-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CD with origin VID/PID != VID/PID #27616
Merged
mergify
merged 5 commits into
project-chip:master
from
cecille:commissioner_dut_cd_with_origin_correct
Jul 7, 2023
Merged
Add CD with origin VID/PID != VID/PID #27616
mergify
merged 5 commits into
project-chip:master
from
cecille:commissioner_dut_cd_with_origin_correct
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CD VID/PID == 0xFFF1/0x8000 (matches existing examples for cd) CD origin VID/PID = 0xFFF2/0x8001 DAC/PAI VID/PID = 0xFFF2/0x8001 Tests: - src/python_testing/test_testing/test_TC_DA_1.2.py (cert test that checks CD cert validity) - credentials/tests/TestCommissionerDUTVectors.cpp (unit test that ensures the test_vector.json is OK) - commissioned all-clusters-app using --dac_provider with chip-tool
PR #27616: Size comparison from 0522ef0 to 615354f Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
July 4, 2023 18:11
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
July 4, 2023 18:11
PR #27616: Size comparison from 0522ef0 to 178ccd4 Increases (11 builds for bl702l, cc32xx, esp32, nrfconnect, qpg, telink)
Decreases (11 builds for cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27616: Size comparison from 7e3aa84 to 883ebc8 Increases (9 builds for bl702l, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, cc32xx, k32w, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 6, 2023
woody-apple
approved these changes
Jul 6, 2023
PR #27616: Size comparison from 21bbc36 to 10c5a03 Increases (9 builds for bl702, bl702l, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, efr32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jul 11, 2023
This uses the pieces put in place in project-chip#27616
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jul 11, 2023
This uses the pieces put in place in project-chip#27616
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jul 12, 2023
This uses the pieces put in place in project-chip#27616
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jul 12, 2023
This uses the pieces put in place in project-chip#27616
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
This uses the pieces put in place in #27616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CD VID/PID == 0xFFF1/0x8000 (matches existing examples for cd)
CD origin VID/PID = 0xFFF2/0x8001
DAC/PAI VID/PID = 0xFFF2/0x8001
Tests: - src/python_testing/test_testing/test_TC_DA_1.2.py
(cert test that checks CD cert validity)
- credentials/tests/TestCommissionerDUTVectors.cpp
(unit test that ensures the test_vector.json is OK)
- commissioned all-clusters-app using --dac_provider
with chip-tool