-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] CommissionOnNetwork blocked if DUT does not have an open commissoning window #27646
Merged
woody-apple
merged 4 commits into
project-chip:master
from
tianfeng-yang:fixed/python-commission-on-network-without-timeout
Jul 19, 2023
Merged
[Python] CommissionOnNetwork blocked if DUT does not have an open commissoning window #27646
woody-apple
merged 4 commits into
project-chip:master
from
tianfeng-yang:fixed/python-commission-on-network-without-timeout
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missioning window
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
July 6, 2023 05:08
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
July 6, 2023 05:09
PR #27646: Size comparison from d55f685 to 181eccf Increases (8 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (10 builds for bl702l, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/controller/python/ChipDeviceController-ScriptPairingDeviceDiscoveryDelegate.cpp
Outdated
Show resolved
Hide resolved
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 10, 2023 08:59
PR #27646: Size comparison from 01116da to bd57e52 Increases (10 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@tcarmelveilleux Can you please review? |
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
…missoning window (project-chip#27646) * [Python] CommissionOnNetwork blocked if DUT does not have an open commissioning window * optimize interfaces * optimize
tianfeng-yang
deleted the
fixed/python-commission-on-network-without-timeout
branch
January 15, 2024 03:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DUT does not have an open commissoning window.
Call Python API
CommissionOnNetwrok
will be blocked.