Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclassify excessive logging in LevelControl and OnOffServer from Pro… #27938

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Reclassify excessive logging in LevelControl and OnOffServer from Pro… #27938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/clusters/level-control/level-control.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void emberAfLevelControlClusterServerTickCallback(EndpointId endpoint)
return;
}

ChipLogProgress(Zcl, "Event: move from %d", currentLevel.Value());
ChipLogDetail(Zcl, "Event: move from %d", currentLevel.Value());

// adjust by the proper amount, either up or down
if (state->transitionTimeMs == 0)
Expand All @@ -267,8 +267,8 @@ void emberAfLevelControlClusterServerTickCallback(EndpointId endpoint)
currentLevel.SetNonNull(static_cast<uint8_t>(currentLevel.Value() - 1));
}

ChipLogProgress(Zcl, " to %d ", currentLevel.Value());
ChipLogProgress(Zcl, "(diff %c1)", state->increasing ? '+' : '-');
ChipLogDetail(Zcl, " to %d ", currentLevel.Value());
milanr-q marked this conversation as resolved.
Show resolved Hide resolved
ChipLogDetail(Zcl, "(diff %c1)", state->increasing ? '+' : '-');

status = Attributes::CurrentLevel::Set(endpoint, currentLevel);
if (status != EMBER_ZCL_STATUS_SUCCESS)
Expand Down
8 changes: 4 additions & 4 deletions src/app/clusters/on-off-server/on-off-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ bool OnOffServer::OnWithTimedOffCommand(app::CommandHandler * commandObj, const
*/
void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
{
ChipLogProgress(Zcl, "Timer callback - Entering callbackc");
ChipLogDetail(Zcl, "Timer callback - Entering callback");

bool isOn = false;
OnOff::Attributes::OnOff::Get(endpoint, &isOn);
Expand All @@ -826,7 +826,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
// Update onTime values
uint16_t onTime = MIN_TIME_VALUE;
OnOff::Attributes::OnTime::Get(endpoint, &onTime);
ChipLogProgress(Zcl, "Timer callback - On Time: %d", onTime);
ChipLogDetail(Zcl, "Timer callback - On Time: %d", onTime);

if (onTime > 0)
{
Expand All @@ -836,7 +836,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)

if (onTime == 0)
{
ChipLogProgress(Zcl, "Timer callback - Turning off OnOff");
ChipLogDetail(Zcl, "Timer callback - Turning off OnOff");

OnOff::Attributes::OffWaitTime::Set(endpoint, 0);
setOnOffValue(endpoint, Commands::Off::Id, false);
Expand All @@ -854,7 +854,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
OnOff::Attributes::OffWaitTime::Set(endpoint, offWaitTime);
}

ChipLogProgress(Zcl, "Timer Callback - wait Off Time: %d", offWaitTime);
ChipLogDetail(Zcl, "Timer Callback - wait Off Time: %d", offWaitTime);

// Validate if necessary to restart timer
if (offWaitTime > 0)
Expand Down