Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chip_tool_guide.md with basicinformation cluster #28077

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

smides-nest
Copy link
Contributor

Update guide to reflect that basic cluster was renamed to basicinformation

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2023
@smides-nest smides-nest marked this pull request as ready for review July 19, 2023 16:13
@andy31415
Copy link
Contributor

@smides-nest apparently we need some restyle fixes here.

@bzbarsky-apple
Copy link
Contributor

@smides-nest restyled failure.

@woody-apple
Copy link
Contributor

Restyle failed, weird. Filing issue, and re-kicking.

Update guide to reflect that `basic` cluster was renamed to `basicinformation`
@woody-apple
Copy link
Contributor

Yup, needs styling to match widths. Will apply.

@woody-apple
Copy link
Contributor

Note: If you hit details on the restyle failure, you can see the patch instructions (https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3376797) here:

NOTE: you can manually apply these fixes by running:
info                                    
info         git checkout <your branch> 
info         curl https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3376797/patch | git am
info         git push                   
info     

@smides-nest
Copy link
Contributor Author

Note: If you hit details on the restyle failure, you can see the patch instructions (https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3376797) here:

NOTE: you can manually apply these fixes by running:
info                                    
info         git checkout <your branch> 
info         curl https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3376797/patch | git am
info         git push                   
info     

Cool! Thanks for the tip. Style failures are new to me as I'm usually quite stylish. :)

@smides-nest
Copy link
Contributor Author

Yup, needs styling to match widths. Will apply.

Thanks for the assist.

@smides-nest smides-nest deleted the patch-2 branch July 20, 2023 06:23
erwinpan1 pushed a commit to erwinpan1/connectedhomeip that referenced this pull request Jul 21, 2023
…#28077)

* Update chip_tool_guide.md with basicinformation cluster

Update guide to reflect that `basic` cluster was renamed to `basicinformation`

* Restyled by prettier-markdown

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fast track review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants