[zephyr] Update BLE advertising data #2821
Conversation
Damian-Nordic
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
pan-apple,
rwalker-apple,
saurabhst,
vivien-apple,
woody-apple and
yufengwangca
as code owners
|
|
||
| #include <setup_payload/QRCodeSetupPayloadGenerator.h> | ||
|
|
||
| #include <logging/log.h> |
There was a problem hiding this comment.
if this file used CHIP logging instead of nrf logging, this facility could be moved into CHIP?
There was a problem hiding this comment.
Since there's currently no application component within CHIP, by "moved into CHIP" you mean e.g. examples/common/chip-app-server?
There was a problem hiding this comment.
No, I suggest moving this to src/setup_payload and including it in the library built there.
examples/common/ really only pertains to code that shouldn't end up in CHIP, like that used to deal with displays, etc.
There was a problem hiding this comment.
I'm not sure.... by moving this code to setup_payload we would introduce a dependency between setup_payload and the platform library and I wonder if what we could potentially benefit from such a change is worth it. I would rather see code which glues underlying CHIP components together in the CHIP "application server" library which is to be created in #2927. What do you think?
For now I think I can remove non-essential parts of the PR which were only meant to address code duplication until #2927 is finished.
Damian-Nordic
force-pushed
the
feature/ble-adv
branch
from
b077898 to
969249a
Compare
Done! |
* Also move QR Code printing code to examples/common to be shared across all examples. * Restyled by whitespace
Damian-Nordic
force-pushed
the
feature/ble-adv
branch
from
969249a to
e4c3be0
Compare
shucks, I wish I'd been able to respond more quickly. ultimately, chip-app-server should end up in src/app #2927 |
Problem
BLE advertising data on Zephyr was not aligned with the spec and other implementations like iOS & ESP32
Summary of Changes
Put all device identification data in the advertising payload (instead of scan response payload)
Set "Rendezvous over BLE" flag in QR Code in nRF Connect examples
By the way, deduplicate code for logging QR Code payload