-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommissioningWindowManager should only listen for platform events when a commissioning window is open. #28311
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-handler-commissioning
Jul 26, 2023
Merged
CommissioningWindowManager should only listen for platform events when a commissioning window is open. #28311
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-handler-commissioning
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a commissioning window is open. Right now, a CommissioningWindowManager starts listening for platform events if a commissioning window is opened, and then never stops. That means it can end up reacting to fail-safe expirations that have nothing to do with a commissioning window (e.g. CASE updates of state that needs a fail-safe). The fix is to not listen for platform events if the commissioning window is closed.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
July 26, 2023 21:14
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 26, 2023 21:14
tcarmelveilleux
approved these changes
Jul 26, 2023
saurabhst
approved these changes
Jul 26, 2023
PR #28311: Size comparison from 7ab043c to 9263325 Increases (57 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, a CommissioningWindowManager starts listening for platform events if a commissioning window is opened, and then never stops. That means it can end up reacting to fail-safe expirations that have nothing to do with a commissioning window (e.g. CASE updates of state that needs a fail-safe).
The fix is to not listen for platform events if the commissioning window is closed.