Make src/transport compile with -Werror=conversion #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
changed the title
rwalker-apple
approved these changes
Sep 25, 2020
bzbarsky-apple
force-pushed
the
int-conversion-transport
branch
from
e07804c to
1d68cc4
Compare
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
mspang and
saurabhst
mspang
approved these changes
Sep 29, 2020
|
@saurabhst @BroderickCarlin @jelderton @hawk248 @chrisdecenzo could you take a look, please? |
saurabhst
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
src/transport does not compile with -Wconversion
Summary of Changes
Make it compile
fixes #2848