-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPSTATE-2.3] Add checks for PICS #28615
Merged
mergify
merged 7 commits into
project-chip:master
from
duyen-tran:duyen-tran/opstate-add-checks-for-pics
Aug 16, 2023
Merged
[OPSTATE-2.3] Add checks for PICS #28615
mergify
merged 7 commits into
project-chip:master
from
duyen-tran:duyen-tran/opstate-add-checks-for-pics
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
August 10, 2023 13:07
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 10, 2023 13:07
bzbarsky-apple
requested changes
Aug 10, 2023
PR #28615: Size comparison from 570eb83 to 345b2f4 Increases (9 builds for bl602, bl702, esp32, nrfconnect, telink)
Decreases (9 builds for bl602, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hicklin
requested changes
Aug 10, 2023
PR #28615: Size comparison from 570eb83 to 03f0d2c Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (23 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
plauric
approved these changes
Aug 11, 2023
bzbarsky-apple
approved these changes
Aug 11, 2023
hicklin
approved these changes
Aug 16, 2023
PR #28615: Size comparison from 71aa96f to bd50d50 Increases (14 builds for bl702, k32w, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702l, efr32, esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* check PICS * remove pause and resume pics guard * Revert "remove pause and resume pics guard" This reverts commit 43b3c0b. * remove pause and resume pics guard * remove the check for paused and running pics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement updates from https://github.com/CHIP-Specifications/chip-test-plans/pull/3316/files
Added a check for
OPSTATE.S.A0002
before reading the CountDowntime attribute