Code

Add missed code review comments#28626

Code

Merged

andy31415 merged 15 commits intoproject-chip:masterproject-chip/connectedhomeip:masterfrom andy31415:add_code_review_for_grpkeyandy31415/connectedhomeip:add_code_review_for_grpkeyCopy head branch name to clipboardAug 10, 2023

+9-5

Commits

Commits on Aug 4, 2023

• Fix KeySetRemove to fail on key set index 0

  Show description for 72dc68d
  tennessee-google

  committed
  72dc68d

  Copy full SHA for 72dc68d

• Regen tests with ZAP

  tennessee-google

  committed
  e58736e

  Copy full SHA for e58736e

• Restyled by clang-format

  

  restyled-commits

  authored and

  tennessee-google

  committed
  1d2b5eb

  Copy full SHA for 1d2b5eb

• Remove explicit check for undefined fabric index

  tennessee-google

  committed
  cd38a66

  Copy full SHA for cd38a66

• Fix build

  tennessee-google

  committed
  4dcc457

  Copy full SHA for 4dcc457

Commits on Aug 8, 2023

• Rename ValidateAndGetProviderAndFabric to just GetProviderAndFabric

  andreilitvin

  committed
  67962a5

  Copy full SHA for 67962a5

Commits on Aug 9, 2023

• Merge branch 'master' into fix-grpkey-remove

  andy31415

  committed
  d3bdf03

  Copy full SHA for d3bdf03

• Added back cleanup for VerifyOrDie argument checking

  andy31415

  committed
  8898519

  Copy full SHA for 8898519

• Restyle

  andy31415

  committed
  f32f721

  Copy full SHA for f32f721

Commits on Aug 10, 2023

• Merge branch 'master' into fix-grpkey-remove

  andreilitvin

  committed
  b3146a7

  Copy full SHA for b3146a7

• Update based on code review comments

  andreilitvin

  committed
  05b6518

  Copy full SHA for 05b6518

• Remove two more flight check comments

  andreilitvin

  committed
  4205e80

  Copy full SHA for 4205e80

• Restyle

  andreilitvin

  committed
  03b4858

  Copy full SHA for 03b4858

• Merge branch 'master' into fix-grpkey-remove

  andreilitvin

  committed
  77a2592

  Copy full SHA for 77a2592

• Fix merge error

  andreilitvin

  committed
  1a7649f

  Copy full SHA for 1a7649f