-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update json/tlv for report using latest json/tlv conversion #28639
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/report_json
Aug 25, 2023
Merged
update json/tlv for report using latest json/tlv conversion #28639
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/report_json
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
August 10, 2023 17:57
andy31415
reviewed
Aug 24, 2023
...controller/java/src/com/matter/controller/commands/pairing/PairOnNetworkLongImReadCommand.kt
Show resolved
Hide resolved
andy31415
reviewed
Aug 24, 2023
andy31415
reviewed
Aug 24, 2023
andy31415
reviewed
Aug 24, 2023
andy31415
reviewed
Aug 24, 2023
andy31415
reviewed
Aug 24, 2023
yunhanw-google
force-pushed
the
feature/report_json
branch
from
August 24, 2023 18:25
dd6c70b
to
87aaf77
Compare
andy31415
reviewed
Aug 24, 2023
yunhanw-google
force-pushed
the
feature/report_json
branch
from
August 24, 2023 18:33
a92b1a8
to
3e20e8c
Compare
PR #28639: Size comparison from 8b7d189 to 3e20e8c Full report (27 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/report_json
branch
from
August 24, 2023 19:48
3e20e8c
to
c39da92
Compare
PR #28639: Size comparison from d807061 to c39da92 Full report (1 build for cc32xx)
|
PR #28639: Size comparison from d807061 to 2e5c069 Full report (19 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
yunhanw-google
force-pushed
the
feature/report_json
branch
from
August 24, 2023 21:17
6798b97
to
b935cf8
Compare
yunhanw-google
force-pushed
the
feature/report_json
branch
from
August 24, 2023 21:21
b935cf8
to
0c3aa18
Compare
PR #28639: Size comparison from 3fae7ff to 0c3aa18 Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 24, 2023
andy31415
reviewed
Aug 24, 2023
src/controller/java/src/chip/devicecontroller/model/ClusterState.java
Outdated
Show resolved
Hide resolved
PR #28639: Size comparison from 3fae7ff to a8ab69f Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27686
Update the json in java/jni report, the payload in report is transformed from "anonymous:type":value to {attributeTag:type:value}
Add getAttributesJson() method to retrieve all attributes Json for cluster.
Test: add e2e test to validate the json for both event and attribute in report