clear dstoffset when DSTOffsetRequired is true #28654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #28654: Size comparison from c57aec6 to 9b95e61 Increases (13 builds for bl602, bl702, cc32xx, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702l, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jrhees-cae
approved these changes
Aug 11, 2023
cecille
reviewed
Aug 11, 2023
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Aug 11, 2023
| if (dstState == TimeState::kActive || dstState == TimeState::kChanged) | ||
| { | ||
| emitDSTStatusEvent(commandPath.mEndpointId, false); | ||
| } | ||
| response.DSTOffsetRequired = true; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| response.DSTOffsetRequired = true; |
There was a problem hiding this comment.
This codepath needs to be exercised in a test....
There was a problem hiding this comment.
If you mean the DSTOffsetRequired, it's tested in cert tests. If you mean the status event cert test timesync 2.11 should hit this path IIUC the states - it checks for dst status events as the dst goes on and off. To be fair, it's failing currently, but the test exists.
There was a problem hiding this comment.
@cecille @fessehaeve I mean that we have a code change here, which is fixing an issue, but there are no test changes. That means this code is not being exercised in (automated) tests.
It's possible there are manual cert tests for this, but ideally we would have automated tests here...
There was a problem hiding this comment.
The gap is not the test, it's the example apps. Static zap means we're not covering all cases in CI. Moving to dynamic app testing would be lovely but is a SDK wide problem
cecille
approved these changes
Aug 17, 2023
|
Going to update branch to get rid of the iotSDK requirement (it's been turned off). |
|
PR #28654: Size comparison from d0da504 to 312b190 Increases (12 builds for cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, bl702l, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Co-authored-by: C Freeman <cecille@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28637