Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adding laundry washer controls to all clusters" #28670

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Revert "Adding laundry washer controls to all clusters" #28670

merged 1 commit into from
Aug 11, 2023

Conversation

woody-apple
Copy link
Contributor

Reverts #28616

@woody-apple woody-apple merged commit d928f3c into master Aug 11, 2023
@woody-apple woody-apple deleted the revert-28616-quickfix/TestAppTE2LaundryWasherControls branch August 11, 2023 23:35
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

PR #28670: Size comparison from 8d1dcf6 to 431d203

Increases (4 builds for telink)
platform target config section 8d1dcf6 431d203 change % change
telink contact-sensor-app tlsr9518adk80d (read/write) 876860 876868 8 0.0
text 590848 590850 2 0.0
pump-app tlsr9518adk80d text 596452 596454 2 0.0
smoke_co_alarm-app tlsr9518adk80d text 594322 594324 2 0.0
temperature-measurement-app tlsr9518adk80d (read/write) 865612 865620 8 0.0
text 582560 582562 2 0.0
Decreases (13 builds for cc32xx, esp32, linux, nrfconnect, telink)
platform target config section 8d1dcf6 431d203 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19423290 19423289 -1 -0.0
esp32 all-clusters-app c3devkit (read only) 1152250 1151430 -820 -0.1
(read/write) 1702612 1702412 -200 -0.0
.dram0.bss 79080 79048 -32 -0.0
.flash.rodata 266704 266536 -168 -0.1
.flash.text 1152250 1151430 -820 -0.1
m5stack (read only) 1193883 1193059 -824 -0.1
(read/write) 550810 550606 -204 -0.0
.dram0.bss 85448 85416 -32 -0.0
.flash.rodata 297684 297512 -172 -0.1
.flash.text 1188499 1187675 -824 -0.1
linux all-clusters-app debug (read only) 5522857 5518193 -4664 -0.1
(read/write) 418504 418176 -328 -0.1
.bss 130560 130464 -96 -0.1
.data.rel.ro 276584 276360 -224 -0.1
.init_array 1312 1304 -8 -0.6
.rodata 336336 336016 -320 -0.1
.text 4808387 4804259 -4128 -0.1
shell debug (read only) 2943601 2939049 -4552 -0.2
(read/write) 151048 150720 -328 -0.2
.bss 60104 60008 -96 -0.2
.data.rel.ro 84280 84056 -224 -0.3
.init_array 1144 1136 -8 -0.7
.rodata 212690 212370 -320 -0.2
.text 2559730 2555714 -4016 -0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1221496 1220412 -1084 -0.1
bss 154644 154612 -32 -0.0
rodata 141868 141696 -172 -0.1
text 845932 845148 -784 -0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1339576 1338624 -952 -0.1
bss 140102 140070 -32 -0.0
rodata 135840 135688 -152 -0.1
text 772940 772180 -760 -0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1073404 1072388 -1016 -0.1
bss 107336 107308 -28 -0.0
text 731648 730836 -812 -0.1
bridge-app tlsr9518adk80d text 647460 647458 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 983160 983152 -8 -0.0
text 686214 686212 -2 -0.0
lighting-app-factory-data tlsr9518adk80d text 693732 693730 -2 -0.0
ota-requestor-app tlsr9518adk80d text 612692 612690 -2 -0.0
thermostat tlsr9518adk80d (read/write) 911452 911444 -8 -0.0
text 621890 621888 -2 -0.0
Full report (38 builds for cc32xx, esp32, linux, mbed, nrfconnect, qpg, telink)
platform target config section 8d1dcf6 431d203 change % change
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 615962 615962 0 0.0
(read/write) 207744 207744 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201184 201184 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 962080 962080 0 0.0
.debug_aranges 109056 109056 0 0.0
.debug_frame 369852 369852 0 0.0
.debug_info 19423290 19423289 -1 -0.0
.debug_line 2814419 2814419 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1597625 1597625 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100591 100591 0 0.0
.debug_str 3427188 3427188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106458 106458 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 496476 496476 0 0.0
.symtab 293440 293440 0 0.0
.text 507384 507384 0 0.0
esp32 all-clusters-app c3devkit (read only) 1152250 1151430 -820 -0.1
(read/write) 1702612 1702412 -200 -0.0
.dram0.bss 79080 79048 -32 -0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 266704 266536 -168 -0.1
.flash.text 1152250 1151430 -820 -0.1
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1193883 1193059 -824 -0.1
(read/write) 550810 550606 -204 -0.0
.dram0.bss 85448 85416 -32 -0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297684 297512 -172 -0.1
.flash.text 1188499 1187675 -824 -0.1
.iram0.text 123311 123311 0 0.0
linux all-clusters-app debug (read only) 5522857 5518193 -4664 -0.1
(read/write) 418504 418176 -328 -0.1
.bss 130560 130464 -96 -0.1
.data 4016 4016 0 0.0
.data.rel.ro 276584 276360 -224 -0.1
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1312 1304 -8 -0.6
.rodata 336336 336016 -320 -0.1
.text 4808387 4804259 -4128 -0.1
all-clusters-minimal-app debug (read only) 4902913 4902913 0 0.0
(read/write) 231392 231392 0 0.0
.bss 126016 126016 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94384 94384 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272102 272102 0 0.0
.text 4400611 4400611 0 0.0
bridge-app debug (read only) 2770593 2770593 0 0.0
(read/write) 132848 132848 0 0.0
.bss 51512 51512 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71408 71408 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214664 214664 0 0.0
.text 2378403 2378403 0 0.0
chip-tool debug (read only) 17528481 17528481 0 0.0
(read/write) 1043136 1043136 0 0.0
.bss 93752 93752 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 936936 936936 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 892049 892049 0 0.0
.text 14610179 14610179 0 0.0
lighting-app debug+rpc+ui (read only) 5242001 5242001 0 0.0
(read/write) 222088 222088 0 0.0
.bss 117744 117744 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337108 337108 0 0.0
.text 4662819 4662819 0 0.0
lock-app debug (read only) 4473057 4473057 0 0.0
(read/write) 202840 202840 0 0.0
.bss 113360 113360 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248038 248038 0 0.0
.text 4015667 4015667 0 0.0
ota-provider-app debug (read only) 4128329 4128329 0 0.0
(read/write) 191872 191872 0 0.0
.bss 113504 113504 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201254 201254 0 0.0
.text 3736755 3736755 0 0.0
ota-requestor-app debug (read only) 4222225 4222225 0 0.0
(read/write) 196184 196184 0 0.0
.bss 114560 114560 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204646 204646 0 0.0
.text 3822931 3822931 0 0.0
shell debug (read only) 2943601 2939049 -4552 -0.2
(read/write) 151048 150720 -328 -0.2
.bss 60104 60008 -96 -0.2
.data 784 784 0 0.0
.data.rel.ro 84280 84056 -224 -0.3
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1144 1136 -8 -0.7
.rodata 212690 212370 -320 -0.2
.text 2559730 2555714 -4016 -0.2
tv-app debug (read only) 5317361 5317361 0 0.0
(read/write) 349856 349856 0 0.0
.bss 241280 241280 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272598 272598 0 0.0
.text 4801123 4801123 0 0.0
tv-casting-app debug (read only) 8296737 8296737 0 0.0
(read/write) 210568 210568 0 0.0
.bss 54208 54208 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 367836 367836 0 0.0
.text 7528739 7528739 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522504 2522504 0 0.0
.bss 219904 219904 0 0.0
.data 5128 5128 0 0.0
.text 1485188 1485188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1221496 1220412 -1084 -0.1
bss 154644 154612 -32 -0.0
rodata 141868 141696 -172 -0.1
text 845932 845148 -784 -0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1339576 1338624 -952 -0.1
bss 140102 140070 -32 -0.0
rodata 135840 135688 -152 -0.1
text 772940 772180 -760 -0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1157328 1157328 0 0.0
bss 154791 154791 0 0.0
rodata 113036 113036 0 0.0
text 810516 810516 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178444 1178444 0 0.0
.bss 101176 101176 0 0.0
.data 744 744 0 0.0
.text 625288 625288 0 0.0
lock-app qpg6105+debug (read/write) 1135500 1135500 0 0.0
.bss 95896 95896 0 0.0
.data 748 748 0 0.0
.text 582340 582340 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1073404 1072388 -1016 -0.1
bss 107336 107308 -28 -0.0
text 731648 730836 -812 -0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 977504 977504 0 0.0
bss 105284 105284 0 0.0
text 670206 670206 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944904 944904 0 0.0
bss 109660 109660 0 0.0
text 647460 647458 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876860 876868 8 0.0
bss 98840 98840 0 0.0
text 590848 590850 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 908164 908164 0 0.0
bss 99464 99464 0 0.0
text 618580 618580 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 983160 983152 -8 -0.0
bss 107516 107516 0 0.0
text 686214 686212 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 994524 994524 0 0.0
bss 111764 111764 0 0.0
text 693732 693730 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1052684 1052684 0 0.0
bss 109088 109088 0 0.0
text 731146 731146 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1084012 1084012 0 0.0
bss 120164 120164 0 0.0
text 751250 751250 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934312 934312 0 0.0
bss 99560 99560 0 0.0
text 621522 621522 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899440 899440 0 0.0
bss 100148 100148 0 0.0
text 612692 612690 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882260 882260 0 0.0
bss 98972 98972 0 0.0
text 596452 596454 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869440 869440 0 0.0
bss 98772 98772 0 0.0
text 586916 586916 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744196 744196 0 0.0
bss 97208 97208 0 0.0
text 478658 478658 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879344 879344 0 0.0
bss 98952 98952 0 0.0
text 594322 594324 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865612 865620 8 0.0
bss 98680 98680 0 0.0
text 582560 582562 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 911452 911444 -8 -0.0
bss 99224 99224 0 0.0
text 621890 621888 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907240 907240 0 0.0
bss 99560 99560 0 0.0
text 617198 617198 0 0.0

abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Aug 15, 2023
@woody-apple
Revert "Adding laundry washer controls to all clusters" (project-chip…
a7ad119 
…#28670)
s07641069 pushed a commit to s07641069/connectedhomeip that referenced this pull request Aug 22, 2023
@woody-apple @s07641069
Revert "Adding laundry washer controls to all clusters" (project-chip…
2624497 
…#28670)
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@woody-apple @HunsupJung
Revert "Adding laundry washer controls to all clusters" (project-chip…
df30c88 
…#28670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woody-apple