-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mei in more templates #28815
Merged
mergify
merged 15 commits into
project-chip:master
from
andy31415:use_mei_in_more_templates
Aug 24, 2023
Merged
Use mei in more templates #28815
mergify
merged 15 commits into
project-chip:master
from
andy31415:use_mei_in_more_templates
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28815: Size comparison from 5df3463 to dfe59ae Full report (1 build for cc32xx)
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PR #28815: Size comparison from bd8c01f to 29dc679 Increases (3 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
approved these changes
Aug 23, 2023
yufengwangca
approved these changes
Aug 24, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Use asMEI in several more tempaltes - specifical chip/framework tool, python and java * Zap regen * Fix accidental deletion * zap regen * More namespacing for data types * zap regen * Ensure IDs headers are included in commands.h * Proper namespacing for chip-tool commands * Use PRIx32 for formatting clusterid and commandid * Also update darwin framework tool to compile * Add ID headers for the darwin framework tool commands template * Fix attribute vs command id usage * Fix typo s/Attribute/Attributes/
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Use asMEI in several more tempaltes - specifical chip/framework tool, python and java * Zap regen * Fix accidental deletion * zap regen * More namespacing for data types * zap regen * Ensure IDs headers are included in commands.h * Proper namespacing for chip-tool commands * Use PRIx32 for formatting clusterid and commandid * Also update darwin framework tool to compile * Add ID headers for the darwin framework tool commands template * Fix attribute vs command id usage * Fix typo s/Attribute/Attributes/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28813 we found that MEI are not used uniformly within the SDK.
This PR adds more MEI usage throughout (and at times replaces code usage with global constant usage instead). MatterIDL changes are part of #28805, this PR addresses: