Revert "[Telink] Move SetRouterPromotion(false) at the end of OpenCom… #28848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missioningWindow (project-chip#25517)" This reverts commit 37c3db9.
…ing window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #28848: Size comparison from 8e77e1a to 7c40f05 Decreases (28 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6, qpg, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@LuDuda FYI |
|
FYI: OpenThread issue is here: openthread/openthread#7745 |
jtung-apple
approved these changes
Aug 23, 2023
|
Also note: This spec change was rejected, so this is also technically non spec compliant. |
LuDuda
approved these changes
Aug 24, 2023
|
Next week will do additional test of old issue. UPD: Can't reproduce old bug with latest chnages. |
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
project-chip#28848) * Revert "[Telink] Move SetRouterPromotion(false) at the end of OpenCommissioningWindow (project-chip#25517)" This reverts commit 37c3db9. * Revert "[Telink] Block device role changing into Router if commissioning window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
project-chip#28848) * Revert "[Telink] Move SetRouterPromotion(false) at the end of OpenCommissioningWindow (project-chip#25517)" This reverts commit 37c3db9. * Revert "[Telink] Block device role changing into Router if commissioning window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes was placed in as a workaround for an OpenThread issue in #25517. This has since been fixed.
Removing this, as at this point it's actually causing pairing failures for some device configurations.