-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TI] Resolve linker reenable ci #28869
Merged
mergify
merged 8 commits into
project-chip:master
from
adabreuti:ResolveLinker_ReenableCI
Aug 25, 2023
Merged
[TI] Resolve linker reenable ci #28869
mergify
merged 8 commits into
project-chip:master
from
adabreuti:ResolveLinker_ReenableCI
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
August 24, 2023 17:26
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 24, 2023 17:26
PR #28869: Size comparison from 6434c50 to 434be86 Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28869: Size comparison from 6434c50 to 953ee75 Increases above 0.2%:
Increases (7 builds for efr32, linux)
Full report (35 builds for cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
approved these changes
Aug 24, 2023
PR #28869: Size comparison from 3fae7ff to fb2a859 Full report (3 builds for cc32xx, qpg)
|
PR #28869: Size comparison from f0a1c52 to b1b7aec Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@adabreuti even though this passed CI in this PR, this broke master: https://github.com/project-chip/connectedhomeip/actions/runs/5977422679/job/16217381923 Will have to revert it. |
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Aug 25, 2023
This reverts commit 8e806c5.
andy31415
added a commit
that referenced
this pull request
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Update Example Applications with proper non-ota linker command files * Re-enable CI For TI platforms * Restyled by gn * Resolve CI Lighting app check --------- Co-authored-by: Restyled.io <commits@restyled.io>
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…t-chip#28893) This reverts commit 8e806c5. Co-authored-by: Andrei Litvin <andreilitvin@google.com>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update Example Applications with proper non-ota linker command files * Re-enable CI For TI platforms * Restyled by gn * Resolve CI Lighting app check --------- Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…t-chip#28893) This reverts commit 8e806c5. Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Re-enables CI for TI platforms, fixes #26957
It also resolves linker command issues/sizing issues which caused the CI to be disabled.
Validated all CC13x2x7 and CC13x4 platforms build OOB.