-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android tv-casting-app: refactored Initialization #28875
Merged
sharadb-amazon
merged 4 commits into
project-chip:master
from
sharadb-amazon:droid-setup-20230823
Aug 25, 2023
Merged
Android tv-casting-app: refactored Initialization #28875
sharadb-amazon
merged 4 commits into
project-chip:master
from
sharadb-amazon:droid-setup-20230823
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
August 24, 2023 21:44
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
August 24, 2023 21:44
PR #28875: Size comparison from 3fae7ff to 548e8da Full report (27 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
sharadb-amazon
force-pushed
the
droid-setup-20230823
branch
from
August 24, 2023 22:40
548e8da
to
92d9107
Compare
PR #28875: Size comparison from f0a1c52 to 92d9107 Increases (1 build for esp32)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Aug 25, 2023
examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingApp.java
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingApp-JNI.cpp
Show resolved
Hide resolved
hawk248
approved these changes
Aug 25, 2023
PR #28875: Size comparison from f0a1c52 to 0a191c7 Increases above 0.2%:
Increases (19 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Full report (19 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #28875: Size comparison from f0a1c52 to 51b3074 Increases above 0.2%:
Increases (10 builds for cc32xx, k32w, linux, mbed, nrfconnect)
Full report (10 builds for cc32xx, k32w, linux, mbed, nrfconnect)
|
PR #28875: Size comparison from f0a1c52 to 624b546 Increases above 0.2%:
Increases (61 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Android tv-casting-app: refactored Initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TvCastingApp.java and TvCastingApp-JNI.h/cpp in the Android tv-casting-app have grown in size and should be broken down. This PR is the first step towards doing that. It introduces a simplified version of the Initialization code and corresponding APIs.
### Change summary
1. Added an InitializationExample.java under tv-casting-app/android. It has a initAndStart menthod which is called by the MainActivity, if and only if GlobalCastingConstants.ChipCastingSimplified is set to true (false by default). While these APIs are being refactored, we will keep this flag off (can be turned to true for local testing)
2. Added a CastingApp.java class where we've added the Initialize(), Start() and Stop() APIs. There are some supporting classes in the "support" namespace and there is a CastingApp-JNI.h/cpp that carries native implementation of a couple of private methods.
Some items are marked TODO - they will be addressed in following PRs, when the dependent workflows (commissioning, CASE, etc) are refactored.
### Testing
Tested by building (with the GlobalCastingConstants.ChipCastingSimplified=true flag set) and running the Android tv-casting-app on Mac to see that it initializes and starts the Matter server.