-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow advertising multiple operational identities on the same fabric on Darwin. #29000
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:register-multiple-identities
Sep 1, 2023
Merged
Allow advertising multiple operational identities on the same fabric on Darwin. #29000
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:register-multiple-identities
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 31, 2023 22:57
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple and
younghak-hwang
August 31, 2023 22:57
PR #29000: Size comparison from 9db615b to cea54ae Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Sep 1, 2023
bzbarsky-apple
changed the title
Allow advertising multiple operational identities on Darwin.
Allow advertising multiple operational identities on the same fabric on Darwin.
Sep 1, 2023
…on Darwin. We need to check the instance name before coalescing registrations, not just the type, because all operational advertisements for a given fabric have the same type.
bzbarsky-apple
force-pushed
the
register-multiple-identities
branch
from
September 1, 2023 13:23
cea54ae
to
9eaeae9
Compare
Fast-tracking platform-specific fix with platform owner review. |
PR #29000: Size comparison from ea3970a to 9eaeae9 Increases (1 build for telink)
Decreases (2 builds for efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 1, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
…on Darwin. (project-chip#29000) We need to check the instance name before coalescing registrations, not just the type, because all operational advertisements for a given fabric have the same type.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…on Darwin. (project-chip#29000) We need to check the instance name before coalescing registrations, not just the type, because all operational advertisements for a given fabric have the same type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to check the instance name before coalescing registrations, not just the type, because all operational advertisements for a given fabric have the same type.