[GN] ESP32 flashing support #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem ESP32 is missing .flash.py support equivalent to EFR32 and NRF5. #### Summary of Changes - Generate flashing wrapper script from ESP32 wifi-echo Makefile. - Added esp32_firmware_utils. - Added subclass hooks for Flasher.make_wrapper() and .parse_argv(). - Added Flasher.format_command() for tool command argument lists. - Use argparse.Namespace directly instead of converting to a dict. - Minor text fixes. Flashing wrapper generation from GN is not included here since there is no GN binary target yet, but would be easy to add based on one of the existing //third_party/*_sdk/*_executable.gni.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
andy31415
approved these changes
Sep 29, 2020
rwalker-apple
approved these changes
Sep 29, 2020
mspang
approved these changes
Sep 29, 2020
saurabhst
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ESP32 is missing .flash.py support equivalent to EFR32 and NRF5.
Summary of Changes
Flashing wrapper generation from GN is not included here since there
is no GN binary target yet, but would be easy to add based on one of
the existing //third_party/_sdk/_executable.gni.