-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set FeatureMap
to 0 in all ConcentrationMeasurement
zapfiles
#29104
Merged
mergify
merged 1 commit into
project-chip:master
from
dysonltd:hotfix/concentration-measurement-zap-feature-map-to-zero
Sep 7, 2023
Merged
Set FeatureMap
to 0 in all ConcentrationMeasurement
zapfiles
#29104
mergify
merged 1 commit into
project-chip:master
from
dysonltd:hotfix/concentration-measurement-zap-feature-map-to-zero
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that we don't accidentally pass CI if the cluster fails to encode it
PR #29104: Size comparison from 0e7d3b7 to a5b1272 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 7, 2023
bzbarsky-apple
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need to get project-chip/zap#543 fixed so this will not be an issue....
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
… so that we don't accidentally pass CI if the cluster fails to encode it (project-chip#29104)
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
… so that we don't accidentally pass CI if the cluster fails to encode it (project-chip#29104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #29098.
CI was still passing when the cluster was not encoding the
FeatureMap
in itsRead
handler as the value in the zapfile was correct and it was falling back onto that.So I thought the zapfile value should be set to an incorrect value so that this doesn't happen again.