-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up MTRClusters/MTRBaseClusters a bit: #29241
Clean up MTRClusters/MTRBaseClusters a bit: #29241
Conversation
PR #29241: Size comparison from f47ce53 to 5e5b91d Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple FYI |
Yeah, I need to figure out whether we actually want this change. |
@ksperling-apple suggested we do MTRGenericCluster and MTRGenericBaseCluster, which I like more than "abstract". That would also let us eventually put any functionality that just needs a cluster id on those interfaces.... |
5e5b91d
to
ee7857a
Compare
PR #29241: Size comparison from c5549a1 to ee7857a Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
1) Introduce MTRGenericBaseCluster/MTRGenericCluster base classes. 2) Move the same-for-every-type initializer implementation to the base class. 3) Move the class-specific initializer declaration (needed to get availability right) to a category so we don't get complaints about incomplete implementation.
ee7857a
to
c7553e4
Compare
PR #29241: Size comparison from 754a938 to c7553e4 Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Fast-tracking platform-specific change with platform owner review. |
PR #29241: Size comparison from 754a938 to 681de18 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
right) to a category so we don't get complaints about incomplete
implementation.
helpers directly in generated code.