-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Support group message #29244
[Android] Support group message #29244
Conversation
PR #29244: Size comparison from f47ce53 to 3410310 Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… add_group_message
…homeip into add_group_message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For private InvokeElement(
ChipPathId endpointId,
You also need to rename endpointId to id, which match what https://github.com/project-chip/connectedhomeip/blob/master/src/app/CommandPathParams.h#L42. has
src/controller/java/src/chip/devicecontroller/GroupKeySecurityPolicy.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/GroupKeySecurityPolicy.java
Outdated
Show resolved
Hide resolved
I understand and modify these codes. Please review this. |
PR #29244: Size comparison from 33052cc to ef5f2ee Increases above 0.2%:
Increases (23 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, qpg, telink)
Decreases (13 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line you need to construct attribute path with
chip::app::ConcreteDataAttributePath(kInvalidEndpointId, pathObj.clusterId, pathObj.attributeId, dataVersion),
I modified. Thank you for your comments. |
PR #29244: Size comparison from 33052cc to b7ccd42 Increases above 0.2%:
Increases (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, qpg, telink)
Decreases (14 builds for bl702, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Implement Android Group message * Add Android if_nameindex * Add groupsetting API * remove test code * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format * Implement Group Setting UI * restyle kotlin * Fix kotlin static code analysis * Modify from comments. * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format * kotlin restyle * Modify return value * Update group id in commandpath * Update kotlin codestyle * Restyled by google-java-format * Restyled by clang-format * Update from comments * Modify write path in group session --------- Co-authored-by: Restyled.io <commits@restyled.io>
Fix #29100
Fix #25448
Fix #25449
Fix #24934
(refer https://github.com/project-chip/connectedhomeip/tree/master/examples/chip-tool/commands/group)